GNOME Bugzilla – Bug 409624
Theme-manager doesn't know theme archives if > 1 theme
Last modified: 2007-08-30 16:57:29 UTC
From https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191195 ---8<--- If you try to drag and drop a gtk theme tarball onto the theme manager that contains more than one theme, only the first theme is installed. Version-Release number of selected component (if applicable): 2.14.1-1.fc5.2 How reproducible: Always Steps to Reproduce: 1. Download http://art.gnome.org/download/themes/gtk2/213/GTK2-H2O-default-2.0.tar.gz 2. Drag to theme-manager 3. Only the first theme installs. (I have reproduced this with multiple themes.) Actual results: One theme installs. Expected results: All themes in tarball should install. Additional info: Pretty straightforward bug. Not a showstopper, but a bit of a annoyance. ---8<--- The whole of gnome-theme-installer.c assumes that there will be only one sub-directory in the archive it extracts, which is false in the case above. Probably needs a quite thorough rethink.
The installer has to inspect the internal structure of the archive to determine what type of theme it is installing. As mentioned above, I would imagine this is going to require quite some work to implement nicely.
Created attachment 85818 [details] [review] support theme packs Here's an attempt to make the installer process multiple themes in one archive as well. I'm not sure the dialog flow is the best there is, but it seems to work fine otherwise. Review appreciated.
Created attachment 85873 [details] [review] support theme packs v2 minor update that gets rid of the awkwardness that resulted from keeping the theme_props struct
It's in appearance...