After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408585 - update icon artwork to comply with tango style guidelines
update icon artwork to comply with tango style guidelines
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] about-me
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-16 13:24 UTC by Jakub Steiner
Modified: 2010-04-16 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icon for the .desktop file (10.86 KB, application/x-bzip)
2007-02-16 14:57 UTC, Jakub Steiner
  Details
the lock icons for authorization in about-me (13.72 KB, application/x-bzip)
2007-02-16 17:36 UTC, Jakub Steiner
  Details
gnome-about-me-use-icon-theme.patch (1.11 KB, patch)
2010-04-09 17:14 UTC, Andreas Proschofsky
accepted-commit_now Details | Review

Description Jakub Steiner 2007-02-16 13:24:50 UTC
There's a couple of artwork that needs an update. 

The capplet icon itself (all sizes). FOr changing passwords, there seems to be a lock icon, needed at 48x48 and having 2 states. 

There is also gnome-about-me-bulb-off.png and gnome-about-me-bulb-on.png, I'm not sure where they are used though.
Comment 1 Jakub Steiner 2007-02-16 14:57:58 UTC
Created attachment 82681 [details]
icon for the .desktop file
Comment 2 Jakub Steiner 2007-02-16 14:59:01 UTC
Currently the icon ships with gnome-icon-theme and is called about-me.png, which doesn't fit into the naming scheme defined by the icon naming spec draft. Need to ponder an appropriate name.
Comment 3 Jakub Steiner 2007-02-16 15:08:08 UTC
Correction, it's actually called user-info.png, not about-me.
Comment 4 Jakub Steiner 2007-02-16 17:36:07 UTC
Created attachment 82689 [details]
the lock icons for authorization in about-me

They come in both SVG and PNG formats, as rsvg needs to get bug #341304 fixed before it renders it properly.
Comment 5 Jakub Steiner 2007-02-16 22:19:48 UTC
Commited to gnome-icon-theme in the end.
Comment 6 Jakub Steiner 2007-02-16 22:20:38 UTC
D'oh, the lock icons still need to go in gnome-control-center.
Comment 7 Thomas Wood 2007-02-21 23:30:28 UTC
If you've added these to gnome-icon-theme, shouldn't the About Me capplet be using icons from the theme rather than installing it's own?
Comment 8 Jakub Steiner 2007-02-22 12:43:24 UTC
Only the app icon has been added to the gnome icon theme. Rodney, what do you reckon would be best for the authorization/lock keys?
Comment 9 Jones Lee 2007-03-02 10:45:11 UTC
The title icon is the old style icon still, i think it need some patch to use git icon instead of its own.
Comment 10 Jones Lee 2008-05-10 10:48:13 UTC
I think we should finalize on the bug, first, I find no icon in the naming-spec that related to 'about-me', so I think the app icon definitely does not belong to theme icon instead it will be capplet's custom named icon. And IMHO, should we add the authorization/lock key to git so it can be reused on other apps aswell? Again, what do you reckon Dobey?
Comment 11 Jones Lee 2008-06-26 01:41:06 UTC
I believe that g-i-t should not ship the app icon, instead g-c-c should ship it under /usr/share/icons/hicolor.


I am really confused about where should the icons go to? Is it /usr/share/icons/hicolor OR is it /usr/share/<appname>/icons/hicolor? According to http://live.gnome.org/GnomeGoals/AppIcon, it seems to me the latter location is the right one.... (confused still)
Comment 12 Jakub Steiner 2010-03-04 11:09:37 UTC
gnome-icon-theme 2.29.1 now ships with two new status icons - changes-prevent and changes-allow. about-me should simply look those up for the dialog.
Comment 13 Andreas Proschofsky 2010-04-09 17:14:44 UTC
Created attachment 158310 [details] [review]
gnome-about-me-use-icon-theme.patch

Patch for using changes-prevent and changes-allow from the icon-them instead of the outdated lock-icons. Guess that would be one of those nice to have improvements for a polished look in GNOME3 ;-)
Comment 14 Jens Granseuer 2010-04-13 16:44:45 UTC
Comment on attachment 158310 [details] [review]
gnome-about-me-use-icon-theme.patch

Do you have access to git? Don't forget to remove those icons, too.
Comment 15 Rodrigo Moya 2010-04-16 15:18:05 UTC
Patch committed to master