After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 40644 - Untrustable uid & gid in file info
Untrustable uid & gid in file info
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: File operations
unspecified
Other All
: Normal minor
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2000-04-26 13:07 UTC by John Sullivan
Modified: 2005-11-29 16:54 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
patch to gnome-vfs that implements the uid and gid bit fields (5.51 KB, patch)
2005-03-14 03:04 UTC, thetroublemaker
none Details | Review
patch to gnome-vfs that implements the uid and gid bit fields (5.51 KB, patch)
2005-03-14 04:31 UTC, thetroublemaker
none Details | Review
patch to nautilus that implements the uid and gid checks (4.27 KB, patch)
2005-03-14 04:34 UTC, thetroublemaker
none Details | Review
Update version of the patch! (11.23 KB, patch)
2005-03-21 03:46 UTC, Christian Kellner
none Details | Review

Description John Sullivan 2001-09-10 01:02:30 UTC
Gnome-vfs has a mechanism for testing whether individual fields of a
GnomeVFSFileInfo struct are valid. For some reason this mechanism does not
include the uid & gid fields. There are several FIXMEs in nautilus-file.c
marking places where this check should be made on the uid & gid fields.



------- Additional Comments From mjs@noisehavoc.org 2000-04-27 04:15:42 ----

This seems like a bizzarre accidental omission.




------- Additional Comments From sullivan@eazel.com 2000-09-08 15:27:09 ----

Setting all bugs to P6 to start official bug-prioritization plan. Please don't
set the priority to anything other than P6 unless you've got the gold seal of
approval for doing so.



------- Additional Comments From eli@eazel.com 2000-10-16 19:31:44 ----

Batch-assigning QA ownership of remaining bugs to eli@eazel.com



------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:02 -------
Comment 1 John Fleck 2001-10-21 03:10:19 UTC
Markng "2.0" so it pops up on the radar. Someone who understands it
better can move it off to "future" if needed.
Comment 2 John Fleck 2002-01-26 04:15:38 UTC
Adding GNOME2 keyword.
Comment 3 Luis Villa 2002-02-25 17:51:02 UTC
Moving down to minor, since there don't seem to be any user-visible
problems related to this.
Comment 4 thetroublemaker 2005-03-14 03:04:16 UTC
Created attachment 38666 [details] [review]
patch to gnome-vfs that implements the uid and gid bit fields

hello all! : ) this is one of my first patches, but i had it reviewed and it
seemed fine. so i'm postin' it here. hope it helps solve the issue! : )

ciao! : )

edoardo
Comment 5 thetroublemaker 2005-03-14 04:31:33 UTC
Created attachment 38670 [details] [review]
patch to gnome-vfs that implements the uid and gid bit fields

hello all! : ) this is one of my first patches, but i had it reviewed and it
seemed fine. so i'm postin' it here. hope it helps solve the issue! : )

ciao! : )

edoardo
Comment 6 thetroublemaker 2005-03-14 04:34:13 UTC
Created attachment 38671 [details] [review]
patch to nautilus that implements the uid and gid checks

hi, this patch wasn't really reviewed by anyone, so i'm not sure whether it
does what it's been made for or not. hope you can have a look at it. in the
meantime i'll send a copy the to nautilus mailin' list. : )

ciao! : )

edoardo
Comment 7 Christian Kellner 2005-03-21 03:46:03 UTC
Created attachment 38994 [details] [review]
Update version of the patch!

Based on the excellent work :) of edoardo I made this version I am about to
commit to cvs head soon (maybe tomorrow morning).
Comment 8 Christian Neumair 2005-04-30 19:55:29 UTC
9 days later, gicmo b0rks HEAD and his patch doesn't apply cleanly anymore. Just
kidding, this is a friendly reminder :).
Comment 9 Christian Neumair 2005-05-09 13:30:59 UTC
Committing this patch could also fix bug 155866.
Comment 10 Christophe Fergeau 2005-06-24 21:25:41 UTC
gicmo, what's up with the patch?
Comment 11 Christian Kellner 2005-06-24 22:08:45 UTC
Well actually that patch is fine, but it will break nautilus, so we have to
first adjust that's code. I don't have time to work on the nautilus part.
Edoardo, did you look into rewriting the nautilus bits?
Comment 12 Luis Villa 2005-07-10 04:17:10 UTC
Edoardo was not cc'd, ccing him now. Edoardo: please take a look, there are some
comments on your patch :)
Comment 13 Christian Kellner 2005-11-29 16:51:13 UTC
Fixed in cvs, now nautilus only has to repsect them. I am going to open a bug
about that.
Comment 14 Christian Kellner 2005-11-29 16:54:26 UTC
-->> bug #155866