GNOME Bugzilla – Bug 40644
Untrustable uid & gid in file info
Last modified: 2005-11-29 16:54:26 UTC
Gnome-vfs has a mechanism for testing whether individual fields of a GnomeVFSFileInfo struct are valid. For some reason this mechanism does not include the uid & gid fields. There are several FIXMEs in nautilus-file.c marking places where this check should be made on the uid & gid fields. ------- Additional Comments From mjs@noisehavoc.org 2000-04-27 04:15:42 ---- This seems like a bizzarre accidental omission. ------- Additional Comments From sullivan@eazel.com 2000-09-08 15:27:09 ---- Setting all bugs to P6 to start official bug-prioritization plan. Please don't set the priority to anything other than P6 unless you've got the gold seal of approval for doing so. ------- Additional Comments From eli@eazel.com 2000-10-16 19:31:44 ---- Batch-assigning QA ownership of remaining bugs to eli@eazel.com ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 21:02 -------
Markng "2.0" so it pops up on the radar. Someone who understands it better can move it off to "future" if needed.
Adding GNOME2 keyword.
Moving down to minor, since there don't seem to be any user-visible problems related to this.
Created attachment 38666 [details] [review] patch to gnome-vfs that implements the uid and gid bit fields hello all! : ) this is one of my first patches, but i had it reviewed and it seemed fine. so i'm postin' it here. hope it helps solve the issue! : ) ciao! : ) edoardo
Created attachment 38670 [details] [review] patch to gnome-vfs that implements the uid and gid bit fields hello all! : ) this is one of my first patches, but i had it reviewed and it seemed fine. so i'm postin' it here. hope it helps solve the issue! : ) ciao! : ) edoardo
Created attachment 38671 [details] [review] patch to nautilus that implements the uid and gid checks hi, this patch wasn't really reviewed by anyone, so i'm not sure whether it does what it's been made for or not. hope you can have a look at it. in the meantime i'll send a copy the to nautilus mailin' list. : ) ciao! : ) edoardo
Created attachment 38994 [details] [review] Update version of the patch! Based on the excellent work :) of edoardo I made this version I am about to commit to cvs head soon (maybe tomorrow morning).
9 days later, gicmo b0rks HEAD and his patch doesn't apply cleanly anymore. Just kidding, this is a friendly reminder :).
Committing this patch could also fix bug 155866.
gicmo, what's up with the patch?
Well actually that patch is fine, but it will break nautilus, so we have to first adjust that's code. I don't have time to work on the nautilus part. Edoardo, did you look into rewriting the nautilus bits?
Edoardo was not cc'd, ccing him now. Edoardo: please take a look, there are some comments on your patch :)
Fixed in cvs, now nautilus only has to repsect them. I am going to open a bug about that.
-->> bug #155866