GNOME Bugzilla – Bug 405626
Overwrite file with the same name quitely.
Last modified: 2020-11-11 19:13:35 UTC
Vermillion_58 with Snv 57(gnome 2.17) Steps: 1. Add a file name test.txt which is null file to file-roller 2. Add another file with the same name test.txt but context is different Expect results: User should be prompted that “already file name exists” Actual results: New file replace the old file.
The bug is also mentionned on https://bugs.launchpad.net/bugs/152303
Still in file-roller 3.2.2 (Debian Wheezy and every Ubuntu version I've tested up to this date). Will this bug celebrate it's 5 year anniversary?
Created attachment 206002 [details] [review] Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller. This is a proof of concept patch.
Again, this is just a proof of concept patch. If anyone has any ideas to improve it, please let me know.
Review of attachment 206002 [details] [review]: Ugh -- there is a small bug and it doesn't conform to the coding style used in the program.
Created attachment 206005 [details] [review] Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller.
If I understand it correctly the report is about asking confirmation before overwriting files inside the archive and not when extracting them.
Yes, I believe so though it isn't stated very clearly. I think the launchpad bug in comment #1 is clearer.
I built File-Roller with the patch in comment #6 and the only difference I've noticed is that extracting is now broken. Nothing happens either when I drag and drop files out of the archive to a directory in Nautilus, or use the Extract button in File-Roller. I've tried this on two different computers running Debian Wheezy.
Interesting. I wrote and tested it under ubuntu-natty. Can you tell me which versions of glib, gtk, etc. you're using?
Sure. Here's a list of all my installed packages: http://pastebin.com/Q5kEKbNV
@Anton, I don't see an obvious reason it doesn't work on your machine. Can you build it with debugging flags and walk through the call with gdb?
Sorry -- I see the bug in the patch. I'm working on another revision now.
Review of attachment 206005 [details] [review]: Major bug that prevents extraction if there are no files being overwritten.
Created attachment 206188 [details] [review] Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller.
Anton, sorry for the trouble. Please try the latest patch.
It's all right. As a proof of concept patch, it works fine, though the final product needs more polishing of course. Also, I just realised that what we are discussing is probably bug #590609 which is about overwriting when extracting. As Paolo Bacchilega mentioned, the description of this bug suggests that it's about overwriting files in an archive when compressing.
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time. If you still use file-roller and if you still see this bug / want this feature in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/file-roller/-/issues/ Thank you for creating this report and we are sorry it could not be implemented (volunteer workforce and time is limited).