After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 405626 - Overwrite file with the same name quitely.
Overwrite file with the same name quitely.
Status: RESOLVED OBSOLETE
Product: file-roller
Classification: Applications
Component: general
2.20.x
Other opensolaris
: Normal normal
: ---
Assigned To: file-roller-maint
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2007-02-08 04:22 UTC by Patrick
Modified: 2020-11-11 19:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller. (2.83 KB, patch)
2012-01-24 18:14 UTC, ayan.george
rejected Details | Review
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller. (2.88 KB, patch)
2012-01-24 18:42 UTC, ayan.george
rejected Details | Review
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller. (2.91 KB, patch)
2012-01-26 14:47 UTC, ayan.george
none Details | Review

Description Patrick 2007-02-08 04:22:34 UTC
Vermillion_58 with Snv 57(gnome 2.17)

Steps:
1. Add a file name test.txt which is null file to file-roller
2. Add another file with the same name test.txt but context is different

Expect results:
User should be prompted that “already file name exists”

Actual results:
New file replace the old file.
Comment 1 Sebastien Bacher 2007-10-15 12:51:32 UTC
The bug is also mentionned on https://bugs.launchpad.net/bugs/152303
Comment 2 Anton Eliasson 2011-12-07 19:16:42 UTC
Still in file-roller 3.2.2 (Debian Wheezy and every Ubuntu version I've tested up to this date). Will this bug celebrate it's 5 year anniversary?
Comment 3 ayan.george 2012-01-24 18:14:34 UTC
Created attachment 206002 [details] [review]
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller.


This is a proof of concept patch.
Comment 4 ayan.george 2012-01-24 18:16:46 UTC
Again, this is just a proof of concept patch.  If anyone has any ideas to improve it, please let me know.
Comment 5 ayan.george 2012-01-24 18:38:22 UTC
Review of attachment 206002 [details] [review]:

Ugh -- there is a small bug and it doesn't conform to the coding style used in the program.
Comment 6 ayan.george 2012-01-24 18:42:31 UTC
Created attachment 206005 [details] [review]
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller.
Comment 7 Paolo Bacchilega 2012-01-24 21:37:06 UTC
If I understand it correctly the report is about asking confirmation before overwriting files inside the archive and not when extracting them.
Comment 8 ayan.george 2012-01-24 21:39:08 UTC
Yes, I believe so though it isn't stated very clearly.  I think the launchpad bug in comment #1 is clearer.
Comment 9 Anton Eliasson 2012-01-25 12:48:27 UTC
I built File-Roller with the patch in comment #6 and the only difference I've noticed is that extracting is now broken. Nothing happens either when I drag and drop files out of the archive to a directory in Nautilus, or use the Extract button in File-Roller. I've tried this on two different computers running Debian Wheezy.
Comment 10 ayan.george 2012-01-25 12:55:19 UTC
Interesting.  I wrote and tested it under ubuntu-natty.  Can you tell me which versions of glib, gtk, etc. you're using?
Comment 11 Anton Eliasson 2012-01-25 13:08:31 UTC
Sure. Here's a list of all my installed packages:
http://pastebin.com/Q5kEKbNV
Comment 12 ayan.george 2012-01-26 10:02:03 UTC
@Anton, I don't see an obvious reason it doesn't work on your machine.  Can you build it with debugging flags and walk through the call with gdb?
Comment 13 ayan.george 2012-01-26 14:27:47 UTC
Sorry -- I see the bug in the patch.  I'm working on another revision now.
Comment 14 ayan.george 2012-01-26 14:46:13 UTC
Review of attachment 206005 [details] [review]:

Major bug that prevents extraction if there are no files being overwritten.
Comment 15 ayan.george 2012-01-26 14:47:38 UTC
Created attachment 206188 [details] [review]
Patch that adds warning dialog when files might be overwritten when extracting by dragging from file-roller.
Comment 16 ayan.george 2012-01-26 14:48:08 UTC

Anton, sorry for the trouble.  Please try the latest patch.
Comment 17 Anton Eliasson 2012-01-26 18:17:28 UTC
It's all right. As a proof of concept patch, it works fine, though the final product needs more polishing of course. Also, I just realised that what we are discussing is probably bug #590609 which is about overwriting when extracting. As Paolo Bacchilega mentioned, the description of this bug suggests that it's about overwriting files in an archive when compressing.
Comment 18 André Klapper 2020-11-11 19:13:35 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time.

If you still use file-roller and if you still see this bug / want this feature in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/file-roller/-/issues/

Thank you for creating this report and we are sorry it could not be implemented (volunteer workforce and time is limited).