After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 389048 - [Advanced Timeline] Improve the ruler
[Advanced Timeline] Improve the ruler
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other All
: Normal minor
: 0.10.2
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-23 22:34 UTC by Ernst Sjöstrand
Modified: 2008-10-11 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ruler patch (3.95 KB, patch)
2006-12-23 22:35 UTC, Ernst Sjöstrand
none Details | Review
New patch (5.78 KB, patch)
2006-12-26 18:06 UTC, Ernst Sjöstrand
committed Details | Review

Description Ernst Sjöstrand 2006-12-23 22:34:59 UTC
Makes the ruler gui look much nicer, and put some restrictions on zoom levels.

Other information:
Comment 1 Ernst Sjöstrand 2006-12-23 22:35:34 UTC
Created attachment 78842 [details] [review]
ruler patch
Comment 2 Edward Hervey 2006-12-24 11:25:45 UTC
nice one :) Due to xmas and all I won't be able to review/commit before tuesday. In fact, if you're up to it, you could add the actual values for every 'second' tick, so you know which position it represents.
Something like hh:mm:ss would be nice.

Thanks a lot, and merry xmas :)
Comment 3 Ernst Sjöstrand 2006-12-24 12:55:12 UTC
hi edward! hmm... I can't figure exactly how that would fit, but perhaps it will show itself if one experiments.

btw, I tried to use the mailinglist, but sourceforge seems a bit broken as usual and my mail didn't seem to get delivered. perhaps move the mailinglist to something more usable?
Comment 4 Ernst Sjöstrand 2006-12-26 18:06:27 UTC
Created attachment 78915 [details] [review]
New patch

New patch that shows the time also. Lot's of if-statements to get that right...
Comment 5 Edward Hervey 2006-12-28 16:45:03 UTC
Cleaned up and commited the patch.

It might still need some more loving though. Like maybe using some bold fonts for some key-points (like the minutes or the hours), in the same way the tics are bigger for minutes or 10s markers.



2006-12-28  Ernst Persson  <ernstp@gmail.com>

	reviewed by: Edward Hervey  <edward@fluendo.com>

	* pitivi/ui/ruler.py:
	Make the ruler nicer. Add time text position.