After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 387482 - Variable modified in signal handler should be volatile
Variable modified in signal handler should be volatile
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-19 11:20 UTC by Bastien Nocera
Modified: 2006-12-20 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vte-HEAD-pty-helper-volatile.patch (522 bytes, patch)
2006-12-19 11:23 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2006-12-19 11:20:59 UTC 
the "done" gboolean in gnome-pty-helper.c should be volatile, or the compiler might optimise the variable out of other functions.
Comment 1 Bastien Nocera 2006-12-19 11:23:37 UTC 
Created attachment 78619 [details] [review]
vte-HEAD-pty-helper-volatile.patch
Comment 2 Behdad Esfahbod 2006-12-19 19:42:15 UTC 
Thanks for the patch.  Have you encountered this problem anywhere, or just spotted it?  I mean, should I worry about an stable release, etc, or just commit to head?
Comment 3 Bastien Nocera 2006-12-20 08:47:33 UTC 
(In reply to comment #2)
> Thanks for the patch.  Have you encountered this problem anywhere, or just
> spotted it?

Just spotted it.

> I mean, should I worry about an stable release, etc, or just
> commit to head?

Probably both, in my opinion, as the problem is more than theoretical
Comment 4 Behdad Esfahbod 2006-12-20 18:35:01 UTC 
Thanks.  I'll create a stable branch and pick bug fixes there.

2006-12-20  Behdad Esfahbod  <behdad@gnome.org>

        Bug 387482 – Variable modified in signal handler should be volatile
        Patch from Bastien Nocera

        * gnome-pty-helper/gnome-pty-helper.c: Make variable "done" volatile.