GNOME Bugzilla – Bug 385143
bookmarks from renamed categories still match the previous category
Last modified: 2016-10-07 21:27:26 UTC
That bug has been described on https://launchpad.net/distros/ubuntu/+source/epiphany-browser/+bug/65716 "After renaiming a bookmarks topic, it is updated in bookmarks menu, but is not recognized in the location bar. Only bookmarks assigned later to the renamed topic appear in the location bar. Example: topic "foo" consists of 3 bookmarks: 1, 2, and 3 rename "foo" to "bar" add bookmark 4 now: typing "foo" in the location bar drops down a menu with bookmarks 1, 2, 3 typing "bar" in the location bar drops down a menu with bookmark 4 http://librarian.launchpad.net/4820471/bookmarks.png ... I reopen, because it doesn't work for me in Edgy either (epiphany 2.16.1). Perhaps I wasn't clear with my description, so I attach screenshots of Bookmarks editor to show what's the problem. There are four bookmarks under "portale" topic. Three of them (BBC, Gazeta and Onet) were added, when the name of the topic was "news". One (WP) was added after the topic name was changed to "portale". You can see what happens, when I enter "news" and "portale" in the search bar (the same happens with the location bar). ... http://librarian.launchpad.net/4820474/bookmarks2.png bookmarks editor view, search for "portale" ... http://librarian.launchpad.net/4820475/bookmarks3.png bookmarks editor view, search for "newsy" ... > Works fine for me on feisty now, maybe you could describe the step you use ... * create a category "foo" * add four bookmarks to it * rename it from the bookmark editor to "bar" * close the bookmark editor * right click on the current browsed page and add it to the new category * open the bookmark editor * type "bar" in the Search bar (I have only one new bookmark) * now type "foo" in the Search bar (here are 4 old bookmarks) * close the bookmark editor * type "foo" in the URL bar (4 old bookmarks) * type "bar" in the URL bar (1 new bookmark) ..."
Aha. This happens. Serious problem (no matter hard to discover).
there's no call to update_bookmark_keywords after the bmk is added to a keyword.
There will be no more 2.18.x releases; moving bugs off of that target milestone.
It's the same in 2.22.1.1 in Ubuntu Hardy.
Fix should be in src/bookmarks/ephy-bookmarks-editor.c I think: static void cmd_rename (GtkAction *action, EphyBookmarksEditor *editor) { if (ephy_node_view_is_target (EPHY_NODE_VIEW (editor->priv->bm_view))) { ephy_node_view_edit (EPHY_NODE_VIEW (editor->priv->bm_view), FALSE); } else if (ephy_node_view_is_target (EPHY_NODE_VIEW (editor->priv->key_view))) { ephy_node_view_edit (EPHY_NODE_VIEW (editor->priv->key_view), FALSE); /* FIXME: for node in keyw: rename */ } add_text_renderer_monitor (editor); }
Reality check.
Hi, the bookmarks code has been rewritten from scratch. When you have a convenient opportunity to test the new version of the code (which will be present in Epiphany 3.23.1) please check to see if your issue is still a problem, and reply here. Thanks!
Hi, this is a mass close of all bugs in the NEEDINFO state. If you think this bug was closed improperly, just leave a comment, thanks!