After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362516 - File extensions should not be selected by default
File extensions should not be selected by default
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
: 515793 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-16 03:00 UTC by Evandro Giovanini
Modified: 2008-02-12 17:57 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch to implement the feature, also removes an unused variable (4.98 KB, patch)
2006-10-27 11:24 UTC, Carlos Garnacho 		committed Details | Review

Description Evandro Giovanini 2006-10-16 03:00:27 UTC 
The "Save as" dialog highlights the full name of the file, including the extension. It should not highlight the extension, like Nautilus does when you rename a file.

For example, saving the GNOME logo from this bugzilla page should highlight "gnome-64" instead of "gnome-64.png".
Comment 1 Carlos Garnacho 2006-10-27 11:24:22 UTC 
Created attachment 75499 [details] [review]
patch to implement the feature, also removes an unused variable

it's ok to commit?
Comment 2 Evandro Giovanini 2007-11-30 11:34:54 UTC 
I tested the patch on gtk+ 2.12.1 and it's working great. Thank you Carlos!
Comment 3 Reinout van Schouwen 2008-02-12 12:10:48 UTC 
*** Bug 515793 has been marked as a duplicate of this bug. ***
Comment 4 Reinout van Schouwen 2008-02-12 12:11:40 UTC 
Ping. Can we get this in for 2.22?
Comment 5 Federico Mena Quintero 2008-02-12 16:05:02 UTC 
(In reply to comment #1)
> Created an attachment (id=75499) [edit]
> patch to implement the feature, also removes an unused variable
> 
> it's ok to commit?

Thanks, Garnacho, looks fine to me!
Comment 6 Matthias Clasen 2008-02-12 17:39:15 UTC 
2008-02-12  Matthias Clasen  <mclasen@redhat.com>

        Skip exensions when selecting filenames in the save-as dialog.
        (#362516, Carlos Garnacho)

        * gtk/gtkfilechooserentry.h:
        * gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_select_filename):
        New function to skip the extension part when selecting a filename.
        (_gtk_file_chooser_entry_set_base_folder): Use it here.

        * gtk/gtkfilechooserdefault.c (gtk_file_chooser_entry_grab_focus):
        ...and here.
Comment 7 Carlos Garnacho 2008-02-12 17:57:51 UTC 
Thanks Matthias for committing, I was about to do it in a while :)