After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359365 - Gconf troubles with aisleriot rules
Gconf troubles with aisleriot rules
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
: 345921 368369 384317 441987 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-03 19:15 UTC by Nickolay V. Shmyrev
Modified: 2012-01-31 23:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Quick and dirty patch (1.26 KB, patch)
2006-10-03 20:04 UTC, Nickolay V. Shmyrev 		needs-work Details | Review
Better patch (4.96 KB, patch)
2006-10-03 23:41 UTC, Nickolay V. Shmyrev 		none Details | Review

Description Nickolay V. Shmyrev 2006-10-03 19:15:16 UTC 
Aisleriot uses /apps/aisleriot/rules/<Translated game name> to store current rules for game, for example for Klondike. It causes wierd behaviour since gconf doesn't allow non-ascii chars in key path. 

After every start of sol with Klondike empty dialog appears reporting about some gconf error. Probably game name should not be translated.

To reproduce:

1. switch to Klondike
2. run LANG=ru_RU.utf8 sol
3. see the dialog
Comment 1 Nickolay V. Shmyrev 2006-10-03 20:04:31 UTC 
Created attachment 73968 [details] [review]
Quick and dirty patch

This patch should solve the problem but I still think it's better use untranslated name. This way settings won't depend on locale.
Comment 2 Andreas Røsdal 2006-10-03 20:20:55 UTC 
Thanks for the "quick and dirtly" patch.

In your opinion, is this patch safe to commit also to the 2.16.x branch of gnome-games?
Comment 3 Nickolay V. Shmyrev 2006-10-03 22:03:49 UTC 
Actually there are similar problems with per-game help invocation (yelp requires untranslated name) and with recent games list. I suspect it's better to make it better.
Comment 4 Nickolay V. Shmyrev 2006-10-03 23:41:21 UTC 
Created attachment 73981 [details] [review]
Better patch

This one does job more correctly. I don't know if it's suitable for stable, it's up to you, but actually it's quite annoying and very high visible bug.
Comment 5 Andreas Røsdal 2006-10-06 19:20:18 UTC 
Nickolay, can you describe how your final patch solves this bug?
Comment 6 Nickolay V. Shmyrev 2006-10-06 19:26:30 UTC 
It uses ascii patch for gconf key which is constructed from untranslated string game_file

@@ -427,8 +399,7 @@ make_option_gconf_key (void)
   GConfSchema *schema;
   GConfValue *def;
 
-  r = g_strconcat (basekey, ugamename, NULL);
-
+  r = g_strconcat (basekey, game_file, NULL);
   sk = g_strconcat ("/schemas", r, NULL);

It also uses function to convert untranslated game_file to id in help index, thus it solve the problem with per-game help.
Comment 7 Andreas Røsdal 2006-10-31 20:07:24 UTC 
*** Bug 368369 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Røsdal 2006-11-08 16:55:14 UTC 
*** Bug 345921 has been marked as a duplicate of this bug. ***
Comment 9 Andreas Røsdal 2006-12-10 11:16:27 UTC 
*** Bug 384317 has been marked as a duplicate of this bug. ***
Comment 10 Christian Persch 2007-06-01 13:37:26 UTC 
*** Bug 441987 has been marked as a duplicate of this bug. ***
Comment 11 Robert Ancell 2012-01-31 23:15:19 UTC 
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!