After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357111 - replace spaces with underscores
replace spaces with underscores
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
2.14.x
Other All
: Normal enhancement
: ---
Assigned To: gnome media maintainers
gnome media maintainers
: 142600 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-21 21:12 UTC by Jon Dodson
Modified: 2014-03-24 16:38 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
sj-strip-pattern-spaces.patch (787 bytes, patch)
2006-10-05 10:15 UTC, Luca Cavalli
committed Details | Review

Description Jon Dodson 2006-09-21 21:12:18 UTC
I know this was labeled as a gnome cd bug.  So relabeling as a sound juicer feature request would be good.

Basically, I have a Sony MP3 cd player(I know, I am a dinosaur, but it was $40 and it works great, burning a cd is trivial).  However, it has a problem with the filename Sound juicer outputs when it creates the mp3s.

Sound Juicer spaces the words between a song when it creats a file like so:

This Song Has A Long Name.mp3

However, my Sony MP3 cd player only recognizes file names with underscores, it does not recognize spaces.  Strange thing, my Sony MP3 stereo in my car works fine with the Sound Juicer song names, go fig.

I like Sound Juicer, however and using Grip to get around adding underscores to all the files I create by hand.  

Could, Sound Juicer offer a underscore filename as a output option in some way?

Thanks in advance.
Comment 1 Luca Cavalli 2006-09-22 16:28:36 UTC
The "Strip special characters" should do exactly this, at least reading at source code comments.
Comment 2 Jon Dodson 2006-10-05 03:50:00 UTC
From my look of it, this bug seems to be fix. 

However, not all special characters are stripped from the latest Sound Juicer version 2.16.1.

Specifically in 2.16.1 you select strip special character, you get a preview of what the character stripping should look like, selecting the first one or:

File Name: "Number Title"

Produces:



/The_Beatles/Help_/07 0 Ticket_To_Ride.ogg

Should that instead be:

/The_Beatles/Help/07_0_Ticket_To_Ride.ogg

So the two issues being, not all spaces are removed and you add a trailing slash to the Album name.

Selecting "Track Title" adds a underscore after the album name.  "Track Artist - Track Title" does not strip all special characters and adds album _

The others are very similar, however the last selection for making it lowercase actually strips all the special characters but adds a trailing underscore to the album name.
Comment 3 Luca Cavalli 2006-10-05 10:15:20 UTC
Created attachment 74042 [details] [review]
sj-strip-pattern-spaces.patch

Yepp, you are right. The patch should fix the problem.
Comment 4 Luca Cavalli 2006-10-09 13:40:08 UTC
Forgot to mark the bug as NEW...
Comment 5 Ross Burton 2006-10-22 20:52:15 UTC
Ahem.  Feel free to commit Luca!
Comment 6 Luca Cavalli 2006-10-22 21:20:00 UTC
Thankyou Ross, bug closed :)

2006-10-22  Luca Cavalli  <lcavalli@cgs.gnome.org>

	* src/sj-extracting.c: (filepath_parse_pattern):
	Replace spaces with underscores in path_patterns and file_patterns
	when "Strip special characters" is selected (#357111).
Comment 7 Ross Burton 2006-12-01 10:20:36 UTC
*** Bug 142600 has been marked as a duplicate of this bug. ***