After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355223 - stickynotes wakes up 10 times per second
stickynotes wakes up 10 times per second
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: stickynotes
2.15.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-10 04:41 UTC by Matthias Clasen
Modified: 2006-09-21 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a patch (2.71 KB, patch)
2006-09-10 04:42 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2006-09-10 04:41:13 UTC
to manually check for clicks on the desktop window; this can be done in
a much better way.
Comment 1 Matthias Clasen 2006-09-10 04:42:20 UTC
Created attachment 72484 [details] [review]
a patch
Comment 2 Allison Karlitskaya (desrt) 2006-09-21 17:16:40 UTC
please kill install_check_click_on_desktop if applicable, add changelog, commit.

thanks for the patch :)
Comment 3 Allison Karlitskaya (desrt) 2006-09-21 17:17:12 UTC
by which i mean applet_check_click_on_desktop_cb, of course.
Comment 4 Matthias Clasen 2006-09-21 18:06:52 UTC
2006-09-21  Matthias Clasen <mclasen@redhat.com>

	Don't install a 10Hz timer to poke at the X event queue. 
	Instead use an event filter. (#355223)
	
	* stickynotes/stickynotes_applet.c (stickynotes_applet_init):
	Install the event filter instead of the timeout.

	* stickynotes/stickynotes_applet_callbacks.c
	(applet_check_click_on_desktop_cb): Removed
	(desktop_window_event_filter): The event filter.
	(install_check_click_on_desktop): Function to install the 
	event filter.

	* stickynotes/stickynotes_applet_callbacks.h: Remove
	applet_check_click_on_desktop_cb here too.