GNOME Bugzilla – Bug 351545
Treeview should have sortalble column headers
Last modified: 2006-09-09 16:27:26 UTC
If the treeview had column headers, they could be used to explain the columns: path, size, percentage, number of objects. They could be used for sorting too, obsoleting the toolbar buttons and the menu item.
Created attachment 71274 [details] [review] Proposed patch This patch may also resolve bug #351534. 2006-08-20 Dennis Cranston <dennis_cranston@yahoo.com> * data/baobab.glade: Remove the sort menu and toolbar items, and add an "Allocated Space" menu item to the view menu. * src/baobab-treeview.c: (create_directory_treeview): Add column headers and setup the appropriate column ids for sorting. Merge the percentage and percentage bar columns into a single column. * src/baobab.c: (prefill_model): Show treeview column headers, (first_row): Hide treeview column headers, (fill_model): Replace "object" with "item" to match nautilus' terminology (main): Set initial state of the "Allocated Space" menu item. * src/callbacks.c: (on_notebook1_switch_page), (on_ck_allocated_activate): Remove the sort callbacks, and add activate callback for "Allocated Space" menu item. * src/callbacks.h: Remove sort callbacks, and add activate callback for "Allocated Space" menu item.
Dennis, can you add a screenshot of how it looks? (I know, I know, I am lazy)
Created attachment 71708 [details] screenshot The attached png is for the lazy boy.... Dennis, just one issue: the window does not auto-resize horizontally to show all the columns, so there is a risk for an unexeperienced user to hidden some relevant data (i.e.: Contents)
I like it! As far as I am concerned I am all for commmitting this after the UI freeze is over. However can you provide a patch that doesn't remove the 'show allocated space' toggle? I think that it's important enough to keep on the toolbar and anyway I think it's better to discuss it in it's own bug. This patch should just fix the treeview headers issue so that it's easier to track cvs history.
Please fix one bug per patch and refer to the bug number in the ChangeLog :)
A patch was committed to CVS HEAD.