GNOME Bugzilla – Bug 351532
Stop button in menu + escape shortcut
Last modified: 2006-09-09 16:30:58 UTC
The stop button on the toolbar has no equivalent menu item (bad UI). It should also respond to the Escape key.
Created attachment 70992 [details] [review] Add Escape Accelerator to Stop Search Button The patch adds the Escape button accelerator to the Stop Search Button on the Toolbar.
I agree. Looks a bit too late to add UI (menu)... but if you feel like doing a patch and asking ui-break approval I would accept the patch gladly :)
(must to clarify, my comment above was submitted before seing Dave's patch) In the mean time Dave's patch looks good to me, though I would like to hear other people opinion before applying as I am always a bit scared to steal so common key bindings... are there window managers which use esc by default? are there other gnome apps using esc in similar situations?
Epiphany uses escape.
Oh, and escape is used in gtk+ to close GtkDialogs.
The one problem with this patch is that unless the toolbar is visible the Escape Accelerator will not work. It may do until after the ui-break, but then we would need to add the menu item as to allow the accelerator to be global.
yes, I agree that we should have the menu item too. As I said above if someone feels like pursuing th ui-breakage request I am fine with it otherwise it'll be 2.17. In the mean time I am fine with the above patch: feel free to commit. (Or ping me if you don't, I don't have time right now to test & commit)
2006-08-16 Wouter Bolsterlee <uws+gnome@xs4all.nl> * data/baobab.glade: Added Escape shortcut for the Stop button. Partly fixes bug #351532. Patch by Dave Meikle. I'm leaving this bug open for a more permanent fix.
A patch was committed to CVS HEAD.