GNOME Bugzilla – Bug 351263
Duplicate items in Alarm menu
Last modified: 2013-09-13 00:51:44 UTC
Please describe the problem: On the Alarms dialog, it is possible to get duplicate items in the Alarm option menu. Steps to reproduce: 1. Open the Preferences dialog to the "Calendar and Tasks" page. 2. In the Alerts section, set the preference to one of the following: Show a reminder 1 Days before every appointment Show a reminder 1 Hours before every appointment Show a reminder 15 Minutes before every appointment 3. Close the Preference dialog 4. Select File -> New -> Appointment and then click the Alarms button. 5. Click the Alarm option menu. Actual results: The second-to-last menu item _always_ shows the user preference that we selected in step 2. So if the user selects one of the three choices given in step 2, you get a duplicate item in the menu. Expected results: Evolution should not display the user preference item if an equivalent item is already in the menu. Does this happen every time? Yes Other information:
Created attachment 70856 [details] [review] Proposed patch
While I'm at it, I also noticed that the patch reveals a misspelling of the word "appointment" in the CAL_MINUTES case: ngettext ("%d minute before appointement", ...) Unfortunately, this gets propagated into the translation files.
seems like i was always too lazy to file this. confirming, setting target milestone - patch attached. srini: *ping*
chen: Can you review this ?
Created attachment 71358 [details] [review] The patch from ubutu forum which fixes the issue, picked from bug 333689 and modified to fit in current cvs
Matthew, thanks for the patch. The patch in comment #1 fixes the issue, but introduces another issue, selecting customize shows -1 as the alarm interval. Fix has been committed to cvs HEAD and gnome-2-14 branch.
Cool, glad you caught the second bug. Should I submit another patch for the "appointement" typo? (I assume each of the .po files need to be patched.)
matthew: yes, please file a seperate bug about the "appointement" typo. we will fix it for 2.9, patching all of the .po file is possible, but the translators do not really like that behaviour (yes, from time to time that discussion takes place at gnome-i18n mailing list ;-).