After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350725 - Copy and paste not working in Day View
Copy and paste not working in Day View
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
2.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 383443 484551 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-10 12:21 UTC by A S Alam
Modified: 2008-12-08 10:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
proposed patch (5.46 KB, patch)
2007-07-10 04:46 UTC, Hiroyuki Ikezoe
none Details | Review
revised patch (9.45 KB, patch)
2007-07-13 07:16 UTC, Hiroyuki Ikezoe
needs-work Details | Review
Tested the patch and seems to crash on pasting the text selected to day view. (3.35 KB, text/plain)
2007-07-16 06:29 UTC, Chenthill P
  Details
fix the crash (9.45 KB, patch)
2007-07-17 23:48 UTC, Hiroyuki Ikezoe
none Details | Review
revised patch (21.05 KB, patch)
2007-07-18 03:25 UTC, Hiroyuki Ikezoe
none Details | Review
revised patch agains actual trunk (21.99 KB, text/plain)
2008-06-03 14:34 UTC, Milan Crha
  Details
temporary patch (22.55 KB, patch)
2008-06-13 07:30 UTC, Hiroyuki Ikezoe
committed Details | Review

Description A S Alam 2006-08-10 12:21:49 UTC
Description of problem:
when try to paste data from Clipboard to Calender's DayView, it is not working,
with Ctrl+V, it also not working

Version-Release number of selected component (if applicable):
evolution-2.7.3-9

How reproducible:
Everytime during paste in Dayview

Steps to Reproduce:
1.Open Evolution
2. goto Calender
3. try to paste data by Right Clicking or Ctrl+V
  
Actual results:
nothing pasted in text area

Expected results:
it should print normally

Additional Infor:
1) ctrl + v does not works, but shift + inesert does works.
2)while editing an appointment summary
directly in day view, but not in the "Appointment" dialog window.
Comment 1 A S Alam 2006-08-10 12:23:13 UTC
filed from Red Hat Bugzilla:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198425
Comment 2 André Klapper 2006-08-10 21:39:28 UTC
reminds me of bug 245829, bug 337787 is similar.
cannot find a bug report yet about this so confirming.
Comment 3 Hiroyuki Ikezoe 2007-07-10 04:46:54 UTC
Created attachment 91528 [details] [review]
proposed patch

Copy calendar event object as TARGET_TYPE_VCALENDAR, and retrieve both TARGET_TYPE_VCALENDAR and text for pasting data.
Comment 4 Hiroyuki Ikezoe 2007-07-10 04:51:06 UTC
Andre, I do not think bug 245829 is similar. That issue is caused by unhandling of selection of text (in maybe EDayView).
Comment 5 Hiroyuki Ikezoe 2007-07-10 05:21:52 UTC
Bug 335881 seems to be the same issue.
Comment 6 Hiroyuki Ikezoe 2007-07-13 07:16:11 UTC
Created attachment 91719 [details] [review]
revised patch

The new patch uses e_text_paste_clipboard() instead of e_cal_component_set_summary().
Comment 7 Chenthill P 2007-07-16 06:29:56 UTC
Created attachment 91844 [details]
Tested the patch and seems to crash on pasting the text selected  to day view.
Comment 8 Chenthill P 2007-07-16 06:51:34 UTC
The patch would paste the text only when the user is editing a particular event's summary. I think what the user wants is to paste the text on a selected time slot. It would be better to paste the text in the selected time slot and leave it in editing mode.
Comment 9 Chenthill P 2007-07-16 07:18:14 UTC
The patch does fix pasting the text using ctrl+v while editing an events summary. 
Comment 10 Hiroyuki Ikezoe 2007-07-17 23:48:43 UTC
Created attachment 91910 [details] [review]
fix the crash

aargh! I made a serious typo in the patch...
Comment 11 Hiroyuki Ikezoe 2007-07-18 03:25:35 UTC
Created attachment 91912 [details] [review]
revised patch

Create a new appointment if some text is copied in clipboard and no appointment is editing.
Comment 12 Srinivasa Ragavan 2007-12-19 08:04:36 UTC
Chen, is the updated patch OK to commit? Would be a nice one IMO
Comment 13 André Klapper 2008-01-02 22:31:02 UTC
really do put put this on the 2.22 list, guys! it's another big step to get evolution into a really usable state.
Comment 14 Srinivasa Ragavan 2008-01-13 11:54:13 UTC
Andre, it is there on the list. Not for 2.21.5. But surely for the next one. 
Comment 15 Matthew Barnes 2008-01-29 18:32:13 UTC
*** Bug 383443 has been marked as a duplicate of this bug. ***
Comment 16 Matthew Barnes 2008-01-29 18:33:41 UTC
*** Bug 484551 has been marked as a duplicate of this bug. ***
Comment 17 Srinivasa Ragavan 2008-02-01 08:41:37 UTC
Ah, it missed for 2.21.90. Chen, let it not mess 2.21.91 
Comment 18 Matthew Barnes 2008-03-11 00:27:53 UTC
Bumping version to a stable release.
Comment 19 Milan Crha 2008-06-03 14:32:22 UTC
With the patch applied (I hope I didn't change there much things in bad way), I still cannot paste text with Ctrl+V, neither with Shift+Ins. Furthermore, when I right click over other event and choose Copy, and then right click over empty space in other time and select Paste, nothing happen. I'm not sure whether I didn't break anything with the patch rewrite, it didn't apply smoothly after almost a year. When testing, then when editing, it pastes the text from clipboard with Ctrl+V and Shift+Ins, but even I can select text with the Shift+arrows, then I cannot Ctrl+C on it and paste it a few letters away. We should do this together, same as Ctrl+X.
Comment 20 Milan Crha 2008-06-03 14:34:26 UTC
Created attachment 112059 [details]
revised patch agains actual trunk

Hiroyuki, can you look at it and maybe extend it to support all the cut/copy/paste things? Thanks in advance.
Comment 21 Hiroyuki Ikezoe 2008-06-10 06:14:16 UTC
Milan, I am sorry for the delay. I just came back from my honeymoon. ;-)

Anyway, I will read your patch, although it takes long time since I hardly remember my last year work! (ToT)
Comment 22 Hiroyuki Ikezoe 2008-06-13 07:28:24 UTC
As far as I read the patch, Milan's modification is totally correct.

My original patch has an issue, freeing copy text before pasting text.

And the patch fixes only pasting operation. Last year, I thought copy operation is an another issue (bug 245829), but I think copy issue is of this bug now.


Comment 23 Hiroyuki Ikezoe 2008-06-13 07:30:11 UTC
Created attachment 112659 [details] [review]
temporary patch

fix freeing copy text problem.
Comment 24 Milan Crha 2008-06-13 08:44:32 UTC
Oh, I do not like words like "temporary" and "patch" so near each other. What do you meant with that?
Comment 25 Milan Crha 2008-11-06 14:35:07 UTC
Hiroyuki, ping, how much temporary it is? Because I see the patch works fine, so we can commit to trunk.
Comment 26 Suman Manjunath 2008-12-08 06:41:02 UTC
Patch committed to SVN trunk in r36841
http://svn.gnome.org/viewvc/evolution?view=revision&revision=36841
Comment 27 Milan Crha 2008-12-08 10:02:29 UTC
As far as it works, closing as fixed.