GNOME Bugzilla – Bug 350725
Copy and paste not working in Day View
Last modified: 2008-12-08 10:02:29 UTC
Description of problem: when try to paste data from Clipboard to Calender's DayView, it is not working, with Ctrl+V, it also not working Version-Release number of selected component (if applicable): evolution-2.7.3-9 How reproducible: Everytime during paste in Dayview Steps to Reproduce: 1.Open Evolution 2. goto Calender 3. try to paste data by Right Clicking or Ctrl+V Actual results: nothing pasted in text area Expected results: it should print normally Additional Infor: 1) ctrl + v does not works, but shift + inesert does works. 2)while editing an appointment summary directly in day view, but not in the "Appointment" dialog window.
filed from Red Hat Bugzilla: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198425
reminds me of bug 245829, bug 337787 is similar. cannot find a bug report yet about this so confirming.
Created attachment 91528 [details] [review] proposed patch Copy calendar event object as TARGET_TYPE_VCALENDAR, and retrieve both TARGET_TYPE_VCALENDAR and text for pasting data.
Andre, I do not think bug 245829 is similar. That issue is caused by unhandling of selection of text (in maybe EDayView).
Bug 335881 seems to be the same issue.
Created attachment 91719 [details] [review] revised patch The new patch uses e_text_paste_clipboard() instead of e_cal_component_set_summary().
Created attachment 91844 [details] Tested the patch and seems to crash on pasting the text selected to day view.
The patch would paste the text only when the user is editing a particular event's summary. I think what the user wants is to paste the text on a selected time slot. It would be better to paste the text in the selected time slot and leave it in editing mode.
The patch does fix pasting the text using ctrl+v while editing an events summary.
Created attachment 91910 [details] [review] fix the crash aargh! I made a serious typo in the patch...
Created attachment 91912 [details] [review] revised patch Create a new appointment if some text is copied in clipboard and no appointment is editing.
Chen, is the updated patch OK to commit? Would be a nice one IMO
really do put put this on the 2.22 list, guys! it's another big step to get evolution into a really usable state.
Andre, it is there on the list. Not for 2.21.5. But surely for the next one.
*** Bug 383443 has been marked as a duplicate of this bug. ***
*** Bug 484551 has been marked as a duplicate of this bug. ***
Ah, it missed for 2.21.90. Chen, let it not mess 2.21.91
Bumping version to a stable release.
With the patch applied (I hope I didn't change there much things in bad way), I still cannot paste text with Ctrl+V, neither with Shift+Ins. Furthermore, when I right click over other event and choose Copy, and then right click over empty space in other time and select Paste, nothing happen. I'm not sure whether I didn't break anything with the patch rewrite, it didn't apply smoothly after almost a year. When testing, then when editing, it pastes the text from clipboard with Ctrl+V and Shift+Ins, but even I can select text with the Shift+arrows, then I cannot Ctrl+C on it and paste it a few letters away. We should do this together, same as Ctrl+X.
Created attachment 112059 [details] revised patch agains actual trunk Hiroyuki, can you look at it and maybe extend it to support all the cut/copy/paste things? Thanks in advance.
Milan, I am sorry for the delay. I just came back from my honeymoon. ;-) Anyway, I will read your patch, although it takes long time since I hardly remember my last year work! (ToT)
As far as I read the patch, Milan's modification is totally correct. My original patch has an issue, freeing copy text before pasting text. And the patch fixes only pasting operation. Last year, I thought copy operation is an another issue (bug 245829), but I think copy issue is of this bug now.
Created attachment 112659 [details] [review] temporary patch fix freeing copy text problem.
Oh, I do not like words like "temporary" and "patch" so near each other. What do you meant with that?
Hiroyuki, ping, how much temporary it is? Because I see the patch works fine, so we can commit to trunk.
Patch committed to SVN trunk in r36841 http://svn.gnome.org/viewvc/evolution?view=revision&revision=36841
As far as it works, closing as fixed.