After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349382 - valgrind uninitialized memory warnings setting partly uninitialized X properties
valgrind uninitialized memory warnings setting partly uninitialized X properties
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.10.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-07-31 03:44 UTC by L. David Baron
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
proposed patch (3.14 KB, patch)
2006-07-31 03:46 UTC, L. David Baron 		none Details | Review

Description L. David Baron 2006-07-31 03:44:25 UTC 
Please describe the problem:
When starting up Mozilla under valgrind with --sync, I see a few uninitialized memory warnings that are due to bugs in GDK.  They're of the "syscall param write(buf) points to uninitialised byte(s)", which is what happens when uninitialized data is sent to the X server.

I'll attach a patch (against cvs trunk, and tested against cvs trunk) that fixes two bugs that I actually observed and one that's a case very similar to one of the ones I observed.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 L. David Baron 2006-07-31 03:46:05 UTC 
Created attachment 69938 [details] [review]
proposed patch
Comment 2 Matthias Clasen 2006-08-15 05:46:07 UTC 
2006-08-15  Matthias Clasen  <mclasen@redhat.com>

        * gdk/x11/gdkdnd-x11.c (gdk_window_register_dnd):
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_decorations):
        (gdk_window_set_functions): Zero out some stack-allocated
        X structures, to avoid valgrind warnings about uninitialized
        memory.  (#349382, David Baron)