After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349280 - Move to GtkStatusIcon (Help kill libegg)
Move to GtkStatusIcon (Help kill libegg)
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 469435 583358 (view as bug list)
Depends on: 409435
Blocks: 349256 410783
 
 
Reported: 2006-07-30 11:18 UTC by Vincent Untz
Modified: 2009-05-20 23:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to migrate EggTrayIcon to GtkStatusIcon (20.60 KB, patch)
2006-08-11 22:00 UTC, Jan Arne Petersen
none Details | Review
Patch to migrate EggTrayIcon to GtkStatusIcon (22.54 KB, patch)
2006-08-12 19:25 UTC, Jan Arne Petersen
needs-work Details | Review

Description Vincent Untz 2006-07-30 11:18:35 UTC
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 James "Doc" Livingston 2006-08-09 14:14:06 UTC
For us this means GtkStatusIcon. Some notes:

* should we keep eggtrayicon for older versions of GTK or pull a copy of GtkStatusIcon into the tree
* GtkStatusIcon doesn't support dnd (but does anyone actually drop files onto the icon?)
* GtkStatusIcon doesn't support scroll events, which we currently respond to by changing the volume
Comment 2 Jan Arne Petersen 2006-08-11 22:00:37 UTC
Created attachment 70748 [details] [review]
Patch to migrate EggTrayIcon to GtkStatusIcon

Regressions as mentioned in #1. No support for GTK+ < 2.10 implemented.
Comment 3 Alex Lancaster 2006-08-12 09:13:46 UTC
(In reply to comment #2)

> Regressions as mentioned in #1. No support for GTK+ < 2.10 implemented.

This is pretty much a deal-breaker for me.  FC-5 is still on GTK 2.8 and FC-4 is on GTK 2.6, I think.  Rhythmbox should still run on 2.8, so we should make a local copy if GTK >=2.10 is not found.

Comment 4 Jan Arne Petersen 2006-08-12 19:25:05 UTC
Created attachment 70791 [details] [review]
Patch to migrate EggTrayIcon to GtkStatusIcon

Regressions as mentioned in comment #1. Support for EggTrayIcon (GTK+ < 2.10) implemented.
Comment 5 Ed Catmur 2007-02-18 22:28:05 UTC
Another regression: 

* GtkStatusIcon doesn't support mouseover events (we use a SexyTooltip for
displaying rich information)

I've filed bug 409435 (blocking here) to look at ways of solving this.
Comment 6 Richard Laager 2008-05-14 02:57:34 UTC
Rhythmbox currently has code for minimizing to tray. This was used as an example of how to properly hint to compiz (where the window went) with regard to Pidgin's tray icon: https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/146461

I suggested there that this code move to GtkStatusIcon. It seems that this will come up for you guys in the course of porting to GtkStatusIcon.
Comment 7 Jonathan Matthew 2009-03-11 02:05:07 UTC
As of gtk 2.16, GtkStatusIcon has everything (as far as I know) we need to provide the same features as the current tray icon.  I think it's too soon to depend on gtk 2.16, so we'll need to keep the eggtrayicon code around for a while longer.
Comment 8 Jonathan Matthew 2009-05-05 12:59:05 UTC
*** Bug 469435 has been marked as a duplicate of this bug. ***
Comment 9 Jonathan Matthew 2009-05-18 02:31:08 UTC
The new status icon plugin uses GtkStatusIcon when built with gtk 2.16 or newer.
Comment 10 Jonathan Matthew 2009-05-20 23:52:53 UTC
*** Bug 583358 has been marked as a duplicate of this bug. ***