After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 342751 - gnome-schedule cannot parse perfectly reasonable crontab lines
gnome-schedule cannot parse perfectly reasonable crontab lines
Status: RESOLVED FIXED
Product: gnome-schedule
Classification: Other
Component: general
1.0.0
Other All
: Normal normal
: ---
Assigned To: GNOME Schedule Maintainers
GNOME Schedule Maintainers
Depends on:
Blocks: 325978
 
 
Reported: 2006-05-24 01:00 UTC by Frank Arnold
Modified: 2006-10-03 14:34 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Valid crontab with problems (487 bytes, text/plain)
2006-05-24 01:02 UTC, Frank Arnold
  Details
Dump of my work (1.26 KB, patch)
2006-05-24 01:17 UTC, Frank Arnold
none Details | Review

Description Frank Arnold 2006-05-24 01:00:08 UTC
Originally reported to Fedora BTS by Karl Kleinpaste:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191714

The problem mentioned in this report could be fixed quite easily. However, by looking at it I found other corner cases that won't work. See attached valid crontab file.

Also attaching a patch that solves some issues, but not everything. I wouldn't apply it, just shows the state of my work. Currently, I don't have much time to dig into it further.

Personally I would try to place the title and icon path comments on separate lines ahead of the entry.
Comment 1 Frank Arnold 2006-05-24 01:02:17 UTC
Created attachment 66101 [details]
Valid crontab with problems
Comment 2 Frank Arnold 2006-05-24 01:17:14 UTC
Created attachment 66102 [details] [review]
Dump of my work
Comment 3 Gaute Hope 2006-05-24 08:17:05 UTC
Just some comments to the original bugpost:
We support different cron daemons, and there might be problems using the parser from one of them, but perhaps it isn't too hard to just port the vixie code to python?  

The TITLE and ICON stuff is a problem, perhaps we could find some other solution for this.. do we need a separate file? 

The gnome-schedule parser is mainly made for crontab records made in gnome-schedule.
Comment 4 Gaute Hope 2006-05-31 15:39:42 UTC
Parsing of entries is located at line 71 in entry.c of vixie-cron source, look for your src.rpm and check it out. This is what we have to support and have to port to python.

vixie-cron v4.1
Comment 5 Gaute Hope 2006-05-31 16:58:13 UTC
As a note, as posted by Frank Arnold. There should be a dialog for setting enivornment variables. Global and local for each job(in the seperate script file).

Comment 6 Gaute Hope 2006-06-01 14:43:00 UTC
Notice the new branch; NEW_CRONTAB_PARSE. Work on porting vixie-cron parsing should be commited here.
Comment 7 Gaute Hope 2006-06-08 21:04:38 UTC
This should be parsed nicely if you check out the latest copy from the NEW_CRONTAB_PARSE branch, doesn't support old gnome-schedule titles and icons.

This is written in more vixie style. A new feature where gs adds a JOB_ID to each task aswell(and to old ones if you edit them) where title and icon, and aswell the future describtion, fields are stored. Have a look in the dir: ~/.gnome/gnome-scheduel/crontab and the files last_id, 1, 2, 3.. as you keep adding/editing tasks.

- gaute
Comment 8 Gaute Hope 2006-09-14 09:30:52 UTC
Merged into HEAD, started making the same for at.
Comment 9 Gaute Hope 2006-10-03 14:34:06 UTC
data files for both. should parse nicely.