After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333789 - dups are both shown as "playing"
dups are both shown as "playing"
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
0.10.x
Other Linux
: Normal major
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 331667 334246 336245 336338 336571 336703 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-07 19:22 UTC by Karel Demeyer
Modified: 2006-04-10 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch v1 (810 bytes, patch)
2006-03-21 03:01 UTC, Koike Kazuhiko
reviewed Details | Review
patch v2 with ChangeLog (1.31 KB, patch)
2006-04-03 14:24 UTC, Koike Kazuhiko
reviewed Details | Review

Description Karel Demeyer 2006-03-07 19:22:57 UTC
Screenshot says more then words can:
http://student.vub.ac.be/~kmdemeye/banshee-dup.png

Note this is not the same file that is 2 times listed but 2 different recordings of 1 song.  So this means the entry in the list that is selected as "playing" is not directly related to the file that is playing ?
Comment 1 Ruben Vermeersch 2006-03-12 13:04:35 UTC
*** Bug 334246 has been marked as a duplicate of this bug. ***
Comment 2 Koike Kazuhiko 2006-03-21 03:01:16 UTC
Created attachment 61663 [details] [review]
patch v1

TreeIter should be compared instead of TrackInfo.
Comment 3 Ruben Vermeersch 2006-03-26 20:52:18 UTC
*** Bug 331667 has been marked as a duplicate of this bug. ***
Comment 4 Ruben Vermeersch 2006-03-27 22:46:54 UTC
*** Bug 336245 has been marked as a duplicate of this bug. ***
Comment 5 Germán Poo-Caamaño 2006-03-28 13:32:04 UTC
*** Bug 336338 has been marked as a duplicate of this bug. ***
Comment 6 Germán Poo-Caamaño 2006-03-28 14:16:56 UTC
I just tested the patch on CVS HEAD and it works fine.  Koike, it's only missing an entry for the ChangeLog.
Comment 7 Germán Poo-Caamaño 2006-04-02 16:23:39 UTC
*** Bug 336571 has been marked as a duplicate of this bug. ***
Comment 8 Germán Poo-Caamaño 2006-04-02 16:29:27 UTC
Koike, may you submit a new patch with an ChangeLog entry?

Take a look at http://live.gnome.org/GnomeLove/SubmittingPatches
Comment 9 Germán Poo-Caamaño 2006-04-02 16:35:10 UTC
*** Bug 336703 has been marked as a duplicate of this bug. ***
Comment 10 Koike Kazuhiko 2006-04-03 13:50:48 UTC
I don't have a permission to submit a patch.
Comment 11 Germán Poo-Caamaño 2006-04-03 14:02:16 UTC
My fault.  I tried to said, uploading the new patch here.
Comment 12 Koike Kazuhiko 2006-04-03 14:24:09 UTC
Created attachment 62672 [details] [review]
patch v2 with ChangeLog
Comment 13 Germán Poo-Caamaño 2006-04-03 14:32:34 UTC
Aaron, what are the chances to apply this patch?  I have tested and it works fine, it solves an issue and it is ready to apply.
Comment 14 Germán Poo-Caamaño 2006-04-04 13:48:07 UTC
I must to regret of my last comment.  While it solves an issue, also it adds another one.

For instance, I tried the following steps:

1. Run banshee with this patch.
2. Search the artist (in my case Lush).
3. Select and play the song that looks duplicated (Scarlet in my case).
4. Clear the search entry.  Depending of your amount of songs it will take a
    couple or seconds or a minute.
5. Sort by artist and move to the song.
6. While still is playing, it doesn't has any mark that shows that.

It does not happen without this patch.
Comment 15 Ruben Vermeersch 2006-04-10 18:52:44 UTC
Moving to the User Interface component.

Doesn't this one fix this?:

2006-04-05  Aaron Bockover  <aaron@abock.org>

        * src/PlaylistView.cs: do not show the same file as playing multiple times

Somebody confirm please.
Comment 16 Germán Poo-Caamaño 2006-04-10 19:49:18 UTC
I can confirm it.  It is fixed in CVS.  Thank you to all.