After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332049 - File alteration monitoring doesn't work for local directories.
File alteration monitoring doesn't work for local directories.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-02-21 16:10 UTC by Wouter Bolsterlee (uws)
Modified: 2006-04-28 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (3.39 KB, patch)
2006-02-21 23:43 UTC, Wouter Bolsterlee (uws)
none Details | Review
Slightly improved patch (3.41 KB, patch)
2006-02-22 00:05 UTC, Wouter Bolsterlee (uws)
accepted-commit_now Details | Review

Description Wouter Bolsterlee (uws) 2006-02-21 16:10:13 UTC
Epiphany automatically reloads local files that have changed on disk. This feature is absolutely amazing and I use it every time I'm designing web pages using my favourite text editor (before the actual coding starts).

However, the view does not automatically reload if a directory's contents change. A tab with file:///tmp/ opened in it should reload if the directory changes.

(I know I can also open a Nautilus window on the specified directory, but it's just inconsistent in Ephy right now.)
Comment 1 Wouter Bolsterlee (uws) 2006-02-21 23:43:17 UTC
Created attachment 59891 [details] [review]
Proposed fix

This patch uses g_file_test and gnome-vfs function to determine whether the current local uri is a file or a directory.

Some additional logic in the gnome-vfs monitor callback determines whether a reload is needed.
Comment 2 Wouter Bolsterlee (uws) 2006-02-22 00:05:39 UTC
Created attachment 59893 [details] [review]
Slightly improved patch

Based on comments from harves on IRC, I did tiny a tiny cleanup.
Comment 3 Wouter Bolsterlee (uws) 2006-03-07 00:03:08 UTC
Can this go in before GNOME 2.14/Ephy 1.10 please?
Comment 4 Christian Persch 2006-03-07 10:47:44 UTC
No, since we're in code freeze. I'll apply it for 1.10.1.
Comment 5 Wouter Bolsterlee (uws) 2006-03-16 12:35:38 UTC
Ping :)
Comment 6 Wouter Bolsterlee (uws) 2006-03-17 14:10:01 UTC
I've committed the patch to HEAD.

2006-03-17  Wouter Bolsterlee  <uws@xs4all.nl>

        * src/ephy-tab.c: (ephy_tab_file_monitor_cb),
        (ephy_tab_update_file_monitor):

        Add support for local directory monitoring (in addition to
        local file monitoring). Bug #332049.


Leaving this bug open. If it turns out to not cause any problems, it should be applied to 2.14.1 as well.
Comment 7 Wouter Bolsterlee (uws) 2006-04-27 21:29:11 UTC
Should this patch be committed to the gnome-2-14 branch?
Comment 8 Christian Persch 2006-04-28 10:36:53 UTC
Yes.
Comment 9 Wouter Bolsterlee (uws) 2006-04-28 10:57:19 UTC
Committed.

2006-04-28  Wouter Bolsterlee  <uws+gnome@xs4all.nl>

        * src/ephy-tab.c: (ephy_tab_file_monitor_cb),
        (ephy_tab_update_file_monitor):

        Backport from HEAD:
        Add support for local directory monitoring (in addition to
        local file monitoring). Bug #332049.