GNOME Bugzilla – Bug 332049
File alteration monitoring doesn't work for local directories.
Last modified: 2006-04-28 10:57:19 UTC
Epiphany automatically reloads local files that have changed on disk. This feature is absolutely amazing and I use it every time I'm designing web pages using my favourite text editor (before the actual coding starts). However, the view does not automatically reload if a directory's contents change. A tab with file:///tmp/ opened in it should reload if the directory changes. (I know I can also open a Nautilus window on the specified directory, but it's just inconsistent in Ephy right now.)
Created attachment 59891 [details] [review] Proposed fix This patch uses g_file_test and gnome-vfs function to determine whether the current local uri is a file or a directory. Some additional logic in the gnome-vfs monitor callback determines whether a reload is needed.
Created attachment 59893 [details] [review] Slightly improved patch Based on comments from harves on IRC, I did tiny a tiny cleanup.
Can this go in before GNOME 2.14/Ephy 1.10 please?
No, since we're in code freeze. I'll apply it for 1.10.1.
Ping :)
I've committed the patch to HEAD. 2006-03-17 Wouter Bolsterlee <uws@xs4all.nl> * src/ephy-tab.c: (ephy_tab_file_monitor_cb), (ephy_tab_update_file_monitor): Add support for local directory monitoring (in addition to local file monitoring). Bug #332049. Leaving this bug open. If it turns out to not cause any problems, it should be applied to 2.14.1 as well.
Should this patch be committed to the gnome-2-14 branch?
Yes.
Committed. 2006-04-28 Wouter Bolsterlee <uws+gnome@xs4all.nl> * src/ephy-tab.c: (ephy_tab_file_monitor_cb), (ephy_tab_update_file_monitor): Backport from HEAD: Add support for local directory monitoring (in addition to local file monitoring). Bug #332049.