GNOME Bugzilla – Bug 330407
Multiple dependant vowel signs (indic) displayed as one
Last modified: 2006-10-16 13:50:01 UTC
Upstreaming a bug orginally filed here, because I won't have the time to look into this anytime soon: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138193 Description of problem: When the same dependant vowel is entered multiple times following a consonant, there is no visual indication available for the same. As a result, its very easy to make spelling mistakes. Version-Release number of selected component (if applicable): pango-1.6.0-7 How reproducible: Every time Steps to Reproduce: 1. LANG=hi_IN.UTF-8 gedit 2. ctrl+space, F6 (switch on iiimf, use phonetic keyboard layout) 3. Enter following key combinations: kooooo, kOOOOO, kiiii, kIIII kuuu, kUUU, keeee, kEEEE Actual results: Even if the vowel sign is repeated over and over again, the display shows just one vowel sign. Expected results: Only one dependant vowel should be attached to the preceding consonant. Repeated vowel signs should be displayed independently of the consonant as a blank dotted circle with the vowel sign. Additional info: the 'k' key corresponds to a vowel, the english vowel keys correspond to hindi dependant vowels in the phonetic keyboard layout. The same problem also exists in Gujarati (gu_IN.UTF-8). Tested on RHEL4B2-20041027.0 using the lohit fonts.
There is this bug in the newest pango, I will try to fix it. :)
Created attachment 59977 [details] [review] Multiple dependant vowel signs (indic) display I wrote a patch to fix this bug, and multiple dependant vowel signs (indic) can display as more, not as one.
Behdad, did you look at this patch ?
Behdad, is this patch OK? :)
Created attachment 70179 [details] [review] my new patch I modified a status bit of stateTable[ ][ ]. I think this status bit is wrong.
LingNing, the two patches are apparently doing different things. Why does one obsolete the other? I don't think this is the right approach to fix this bug. We need a general solution to invalid marks. Putting them on top of a dotted circle is one solution that has been discussed here in bugzilla and easy to achieve.
I think the two patches are doing the same thing that displaying multiple dependant vowel signs. But the first patches is complex. Why is not it right? I found that the reason that creating this bug is that _dv of stateTable[][] will go into a dead cycle when it will display multiple dependant vowel signs. And a dotted circle is existing when a dependant vowel sign is rendering. Do you not find it?
Ok, so you think the table change fixes the bug completely?
yes, It can fix the bug completely.
This one is a bit different than other table changes we've been making recently as it affects all Indic languages. Will commit for the next release though.
2006-10-16 Behdad Esfahbod <behdad@gnome.org> Bug 330407 – Multiple dependant vowel signs (indic) displayed as one Patch from LingNing Zhang * modules/indic/indic-ot-class-tables.c: Change state transition for cn to dv.