After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329559 - gnome-terminal cannot fold preedit area.
gnome-terminal cannot fold preedit area.
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
0.11.x
Other All
: Normal normal
: ---
Assigned To: Chris Wilson
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-02 05:46 UTC by Takao Fujiwara
Modified: 2021-06-10 13:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6

Attachments
Snapshot for gnome-terminal (15.08 KB, image/png)
2006-02-02 05:50 UTC, Takao Fujiwara 		  Details
Snapshot for gnome-terminal (12.05 KB, image/png)
2006-02-02 05:51 UTC, Takao Fujiwara 		  Details
Patch for src/vte.c (4.90 KB, patch)
2006-02-02 05:51 UTC, Takao Fujiwara 		needs-work Details | Review

Description Takao Fujiwara 2006-02-02 05:46:13 UTC 
Please describe the problem:
When I input many 'a' beyond the edge of the window. the preedit area is not folded.

I'm attaching the patch and the snapshot before applying the patch and after
applying.



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Takao Fujiwara 2006-02-02 05:50:03 UTC 
Created attachment 58564 [details]
Snapshot for gnome-terminal

This is a snapshot before applying the patch.
Comment 2 Takao Fujiwara 2006-02-02 05:51:06 UTC 
Created attachment 58565 [details]
Snapshot for gnome-terminal

This is a snapshot after applying the patch.
Comment 3 Takao Fujiwara 2006-02-02 05:51:49 UTC 
Created attachment 58566 [details] [review]
Patch for src/vte.c

Attached the patch.
Comment 4 Takao Fujiwara 2006-10-25 07:24:46 UTC 
Could you review the patch?
Comment 5 Takao Fujiwara 2007-02-21 15:16:15 UTC 
How is the status?
Comment 6 Chris Wilson 2007-02-21 15:37:00 UTC 
I've not applied it yet, as I've been focussing on making sure I've fixed all regressions from 0.14. (Though that may come as a surprise to Behdad ;-)

The aspect of the patch I don't understand is the use of preedit_invalid. Also invalidate_cursor_once() needs to be fixed up to correctly invalidate the cells underneath the folded preedit.
Comment 7 Takao Fujiwara 2007-03-08 11:36:20 UTC 
Sorry, I cannot remember why I added preedit_invalid since this is an old patch.
At the moment, it's ok to ignore preedit_invalid unless I remember it.

I await you integrate this fix.
Thanks.
Comment 8 Behdad Esfahbod 2009-03-26 04:41:37 UTC 
Can someone update the patch to current vte please?
Comment 9 GNOME Infrastructure Team 2021-06-10 13:22:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/1119.