After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 328210 - configure --enable-sm doesn't work if -lSM is outside METACITY_LIBS
configure --enable-sm doesn't work if -lSM is outside METACITY_LIBS
Status: VERIFIED FIXED
Product: metacity
Classification: Other
Component: general
2.13.x
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2006-01-22 20:26 UTC by Alexey Rusakov
Modified: 2009-03-06 15:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14



Description Alexey Rusakov 2006-01-22 20:26:04 UTC
Please describe the problem:
If -lSM is not specified in METACITY_LIBS before running configure script, and
it is not required by X libraries (X.org 7.0 seems to be the case), configure
--enable-sm fails saying that -lSM is not found. I observe this bug on Metacity
2.13.34.

Steps to reproduce:
1. Ensure that METACITY_LIBS variable does not contain -lSM, neither do X11
libraries' requirements (X.org 7.0 seems to be the case). Also make libSM.*
libraries are installed.
2. Invoke 'configure --enable-sm'.


Actual results:
configure script fails, reporting that -lSM is not found.

Expected results:
configure script passes, finding -lSM at its usual place.

Does this happen every time?
Yes.

Other information:
The problem seems to be concerned with this part of configure.in:

found_sm=no
case "$METACITY_LIBS" in
 *-lSM*)
    found_sm=yes
    ;;
 *)
  AC_CHECK_LIB(SM, SmcSaveYourselfDone, 
               [AC_CHECK_HEADERS(X11/SM/SMlib.h,
                                METACITY_LIBS="-lSM -lICE $METACITY_LIBS"
found_sm=no)],
               , $METACITY_LIBS)
    ;;
esac

In the second branch, found_sm is set to no, while it should be set to yes, if I
understand things correctly.
Comment 1 Thomas Thurman 2008-02-18 01:34:43 UTC
I'm always a little wary of messing with autotools, but after reading over the code a few times and double-checking the manual, I'm sure you must be right. Fixed.

http://svn.gnome.org/viewvc/metacity?rev=3579&view=rev
Comment 2 Alexey Rusakov 2008-02-18 13:53:53 UTC
Thanks! :)