GNOME Bugzilla – Bug 327235
Refactor gpm-hal-callback into gpm-hal-monitor
Last modified: 2006-01-19 20:27:45 UTC
gpm-hal-callback setups callbacks which gpm-hal-monitor converts to signal. This could be easily done in the same class.
Yes, this is a good idea, agreed.
OK, I'm working on this now.
Cool, thanks Jon.
Created attachment 57668 [details] [review] patch Can you please give this a try?
Works for me. Also good practice to let each other know if we are working on something. We should definitly do that
I'm guessing the gpm-hal-callback files then become redundant right? The patch looks good for me, but you'll have to remove those other files, patch Makefile.am, and POTFILES.po, but I'm sure you've got that covered. Thanks for doing all this work Jon, it's appreciated. We should all meet up and get drunk togeter at a conference or something... Good to commit. R.
Committed with changelog, etc. No prob dude. Sounds good about meeting up. I'll haven't managed to get to any conferences yet. Looking forward to it though. :)
Thanks Jon, appreciated.