After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327235 - Refactor gpm-hal-callback into gpm-hal-monitor
Refactor gpm-hal-callback into gpm-hal-monitor
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
unspecified
Other Windows
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-01-16 17:14 UTC by Jaap A. Haitsma
Modified: 2006-01-19 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (15.44 KB, patch)
2006-01-19 19:04 UTC, William Jon McCann
committed Details | Review

Description Jaap A. Haitsma 2006-01-16 17:14:52 UTC
gpm-hal-callback setups callbacks which gpm-hal-monitor converts to signal. This could be easily done in the same class.
Comment 1 Richard Hughes 2006-01-16 21:03:57 UTC
Yes, this is a good idea, agreed.
Comment 2 William Jon McCann 2006-01-19 16:50:16 UTC
OK, I'm working on this now.
Comment 3 Richard Hughes 2006-01-19 16:55:56 UTC
Cool, thanks Jon.
Comment 4 William Jon McCann 2006-01-19 19:04:23 UTC
Created attachment 57668 [details] [review]
patch

Can you please give this a try?
Comment 5 Jaap A. Haitsma 2006-01-19 19:47:34 UTC
Works for me.

Also good practice to let each other know if we are working on something. We should definitly do that
Comment 6 Richard Hughes 2006-01-19 20:11:15 UTC
I'm guessing the gpm-hal-callback files then become redundant right?

The patch looks good for me, but you'll have to remove those other files, patch Makefile.am, and POTFILES.po, but I'm sure you've got that covered.

Thanks for doing all this work Jon, it's appreciated. We should all meet up and get drunk togeter at a conference or something...

Good to commit.

R.
Comment 7 William Jon McCann 2006-01-19 20:25:34 UTC
Committed with changelog, etc.

No prob dude.  Sounds good about meeting up.  I'll haven't managed to get to any conferences yet.  Looking forward to it though.  :)
Comment 8 Richard Hughes 2006-01-19 20:27:45 UTC
Thanks Jon, appreciated.