After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325707 - gtk_progress_bar_set_fraction called with fraction=1.283203125
gtk_progress_bar_set_fraction called with fraction=1.283203125
Status: RESOLVED FIXED
Product: bug-buddy
Classification: Deprecated
Component: general
2.12.x
Other Linux
: Normal critical
: ---
Assigned To: Bug-buddy Maintainers
Bug-buddy Maintainers
: 325069 326068 327018 (view as bug list)
Depends on: 325861
Blocks:
 
 
Reported: 2006-01-04 01:00 UTC by Christian Kirbach
Modified: 2006-08-11 09:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
compute fraction and set it to 1 if greter than 1 (1.00 KB, patch)
2006-01-05 16:18 UTC, Christian Kirbach
committed Details | Review

Description Christian Kirbach 2006-01-04 01:00:15 UTC
latest bug-buddy from cvs

  • #0 IA__g_logv
    at gmessages.c line 503
  • #1 IA__g_log
    at gmessages.c line 517
  • #2 IA__g_return_if_fail_warning
    at gmessages.c line 532
  • #3 IA__gtk_progress_set_percentage
    at gtkprogress.c line 586
  • #4 IA__gtk_progress_bar_set_fraction
    at gtkprogressbar.c line 1011
  • #5 async_update
    at bugzilla.c line 283
  • #6 dispatch_sync_job_callback
    at gnome-vfs-job.c line 282

Comment 1 Fernando Herrera 2006-01-04 16:51:33 UTC
Same here, it seems to be a problem on gnome_vfs_async_xfer callback that returns wrong values for sizes:
(gdb) p *info
$6 = {status = GNOME_VFS_XFER_PROGRESS_STATUS_OK, vfs_status = GNOME_VFS_OK,
  phase = GNOME_VFS_XFER_PHASE_COPYING,
  source_name = 0x8e98f78 "http://bugzilla.gnome.org/bugzilla.gnome.org/bugzilla-config.xml",
  target_name = 0x8e90750 "file:///home/fer/.gnome2/bug-buddy.d/bugzilla/gnome/config.tmp",
  file_index = 2, files_total = 6, bytes_total = 6144, file_size = 0, bytes_copied = 0,
  total_bytes_copied = 6946, duplicate_name = 0x8e81a58 "config.tmp", duplicate_count = 0,
  top_level_item = 1, reserved1 = 0xb7c4a218, reserved2 = 0x3c71a8}

where total_bytes_copied should not be greater than bytes_total. It seems that bytes_total shows only the size for the first file.
Comment 2 Christian Kirbach 2006-01-04 21:53:27 UTC
have you filed a gnome-vfs report about this?

a temporary hack would simply set fraction=1 if fraction>1
Comment 3 Fernando Herrera 2006-01-05 13:51:24 UTC
Ok, I filled the gnome-vfs bug and making this depend on that. I dislike the temp hack because I don't like to obscure real bugs. Let me try to fix it :)
Comment 4 Christian Kirbach 2006-01-05 15:53:31 UTC
I don't like temp hacks either, but in this case I'd do it because we need a working bug-buddy :)
I am thinking about a compiler #warning in the code so that the temp hack will not be forgotten.
Comment 5 Christian Kirbach 2006-01-05 16:18:58 UTC
Created attachment 56819 [details] [review]
compute fraction and set it to 1 if greter than 1

fixes critical warning.
should be removed if the gnome-vfs issue has been resolved.
Comment 6 Fernando Herrera 2006-01-05 17:15:25 UTC
*** Bug 325069 has been marked as a duplicate of this bug. ***
Comment 7 Christian Kirbach 2006-01-07 18:59:10 UTC
*** Bug 326068 has been marked as a duplicate of this bug. ***
Comment 8 Christian Kirbach 2006-01-12 21:22:27 UTC
The gnome-vfs bug has been fixed on which this bug depends on.

Fer, I suggest you make a release (you wanted anyways if I remember correctly)
and then undo the patch and close this report.
Comment 9 Olav Vitters 2006-01-15 00:51:54 UTC
*** Bug 327018 has been marked as a duplicate of this bug. ***
Comment 10 Christian Kirbach 2006-01-30 00:06:34 UTC
fer, I believe the temporary patch can be backed out.
Comment 11 Christian Kirbach 2006-04-14 18:22:03 UTC
I just tested - can be removed savely now.
Comment 12 Christian Kirbach 2006-08-11 09:28:13 UTC
the code is gone in latest bug-buddy and the gnome-vfs issue has been solved.