GNOME Bugzilla – Bug 323941
False positives in link-guessing for ftp.png
Last modified: 2021-05-19 12:12:38 UTC
This bug was originally reported here, sorry for now upstreaming it earlier: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=137629 Description of problem: Evolution seems to think the text "gnome-fs-ftp.png" should be a link. Specifically, the "ftp.png" part - "ftp://ftp.png". It seems pretty obvious that this should not be a link to me. Here are some possible criteria to consider for the following question: Should this string be a link, even though it lacks a protocol prefix (like 'http://') and any slashes? - NO if there are less than 2 dots in it (skip things like www.foo, ftp.foo) - NO if there is random junk before it (like 'gnome-fs-') - NO if the characters between the last dot and the end of the string are on a blacklist of common file extensions (but what about .COM files ;) - YES if the characters between the last dot and the end of the string are on a whitelist of valid TLDs Obviously, the last criterion would be both slow and a pain to maintain, and the third one would be highly subjective. Personally, I like the first two... any ideas? Version-Release number of selected component (if applicable): Originally seen with evolution-2.0.2-3 on Fedora Confirmed with evolution-2.5.2-1 on Fedora Screenshot of the problem: https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=105958 Last time I checked, code in e-utils/e_text_to_html_full does a !strncasecmp (cur, "ftp://", 6) which ought to work properly, so I suspect something else is at fault here; haven't yet tried single-stepping through the logic though.
could be gtkhtml\parsing
this code is in camel, actually, not gtkhtml
Bumping version to a stable release.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines and create a new bug report ticket at https://gitlab.gnome.org/GNOME/evolution/-/issues/ Thank you for your understanding and your help.