After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322084 - Misuse of == instead of =
Misuse of == instead of =
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.8.x
Other Mac OS
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-21 23:11 UTC by Daniel Macks
Modified: 2005-11-22 07:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Daniel Macks 2005-11-21 23:11:12 UTC
Version details: 2.8.0.6

gdmlogin.c: In function `gdm_login_parse_config':
gdmlogin.c:925: warning: statement with no effect
gdmlogin.c:927: warning: statement with no effect
gdmlogin.c: In function `gdm_reread_config':
gdmlogin.c:3517: warning: statement with no effect
gdmlogin.c:3519: warning: statement with no effect
greeter.c: In function `greeter_parse_config':
greeter.c:260: warning: statement with no effect
greeter.c:262: warning: statement with no effect
greeter.c: In function `greeter_reread_config':
greeter.c:1009: warning: statement with no effect
greeter.c:1011: warning: statement with no effect

These are all constructs like
    if (strcmp (ve_sure_string (GdmWelcome), GDM_DEFAULT_WELCOME_MSG) == 0)
        GdmDefaultWelcome == TRUE;
where the second line should almost certainly be:
        GdmDefaultWelcome = TRUE;
instead.
Comment 1 Brian Cameron 2005-11-22 07:51:37 UTC
Fixed in 2.12 branch.  Already fixed in CVS head.