After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321395 - Little code improvement in eog-wrap-list.{c,h}
Little code improvement in eog-wrap-list.{c,h}
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: collection
git master
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-13 20:48 UTC by Claudio Saavedra
Modified: 2005-11-14 04:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
proposed improvement. (9.87 KB, patch)
2005-11-13 20:52 UTC, Claudio Saavedra 		none Details | Review
patch a little improved. (9.66 KB, patch)
2005-11-13 21:02 UTC, Claudio Saavedra 		none Details | Review

Description Claudio Saavedra 2005-11-13 20:48:44 UTC 
Please describe the problem:
The functions eog_wrap_list_select_[up,down,left,right,first,last] () are nearly
similar. I wrote a single function to reduce a little the size of the source code.  

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Claudio Saavedra 2005-11-13 20:52:21 UTC 
Created attachment 54714 [details] [review]
proposed improvement.
Comment 2 Claudio Saavedra 2005-11-13 21:02:04 UTC 
Created attachment 54715 [details] [review]
patch a little improved.
Comment 3 Lucas Rocha 2005-11-14 04:22:07 UTC 
Nice catch! Applied in HEAD, thanks!