After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 319190 - f-spot eats my jpegs when i try to rotate them
f-spot eats my jpegs when i try to rotate them
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Editing
0.0.x
Other Linux
: Urgent critical
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2005-10-18 22:07 UTC by sam tygier
Modified: 2009-07-27 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a healthy jpeg (130.66 KB, image/jpeg)
2005-10-19 07:28 UTC, sam tygier
  Details
the broken jpeg (130.76 KB, image/jpeg)
2005-10-19 07:30 UTC, sam tygier
  Details
fix for endian issue (871 bytes, patch)
2005-10-19 16:38 UTC, Larry Ewing
none Details | Review

Description sam tygier 2005-10-18 22:07:21 UTC
Distribution/Version: ubuntu 5.10 (breezy)

this happens to any jpeg i try to rotate.

i import a jpeg file (made with dcraw and imagemagick)
select it
click either rotate button
photo is replaced with big question mark
the original photo is corrupted, it cannot be read with eog or gimp

the output on the terminal

sam@titania:~$ f-spot 
Unable to find active server: Name 'org.gnome.FSpot' does not exist.
Saving orientation as RightTop
value = f-spot version 0.1.3 len = 20
value = 2005:10:18 22:58:06 len = 19
value = 2005:10:18 22:58:06 len = 19
value = f-spot version 0.1.3 len = 20
value = 2005:10:18 22:58:06 len = 19
Saved 98 bytes
saving marker Soi (null)
saving marker App0 14
saving marker App1 98
saving marker Dqt 65
saving marker Dqt 65
saving marker Sof0 15
saving marker Dht 27
saving marker Dht 71
saving marker Dht 25
saving marker Dht 51
saving marker Sos 10
Error loading image /home/sam/Desktop/playphotos/crw_6366.jpeg
GLib.GException: Error interpreting JPEG image file (JPEG datastream contains no
image)
in <0x000bc> Gdk.PixbufLoader:Write (System.Byte[] buf, UInt64 count)
in <0x0013c> FSpot.AsyncPixbufLoader:AsyncRead ()
Falling back to file loader

i am running f-spot on ubuntu 5.10 (breezy) on an apple powerbook g4
Comment 1 Larry Ewing 2005-10-19 04:18:22 UTC
eep this is terrible, can you attach one of the corrupt images to this bug?
Comment 2 Larry Ewing 2005-10-19 04:19:48 UTC
Can you also attach one the same image before it is garbled?
Comment 3 sam tygier 2005-10-19 07:28:09 UTC
Created attachment 53637 [details]
a healthy jpeg

This is the photo before it is opened in f-spot.
Comment 4 sam tygier 2005-10-19 07:30:28 UTC
Created attachment 53638 [details]
the broken jpeg

This is the jpeg after f-spot has attempted to rotated it
Comment 5 Larry Ewing 2005-10-19 16:37:59 UTC
ok this was a byte order problem on big endian machines that should be fixed
now.  If you would like me to recover any images that f-spot corrupted let me
know, it should be a simple process.  I'll attach the patch so you can test it
if you like.
Comment 6 Larry Ewing 2005-10-19 16:38:35 UTC
Created attachment 53662 [details] [review]
fix for endian issue
Comment 7 sam tygier 2005-10-19 17:03:20 UTC
wow quick work

everything was backed up so i didn't loose any data.

i am not really sure how to aply the patch, f-spot is installed from a .deb from
the ubuntu universe. is there someway to download a source deb? i'll pester the
ubuntu devs to get this into ubuntu quickly.

thank you
Comment 8 Hubert Figuiere (:hub) 2005-10-19 17:24:09 UTC
bug reproduced.

The patch definitely fix the problem.

I did rebuild a package with it.
Comment 9 Gabriel Burt 2005-10-25 22:38:47 UTC
Fixed in CVS.