After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317604 - Update libvte-java to work with Java-GNOME 2.8/2.12
Update libvte-java to work with Java-GNOME 2.8/2.12
Status: VERIFIED FIXED
Product: java-gnome
Classification: Bindings
Component: VTE
mainline
Other Linux
: Normal normal
: ---
Assigned To: java-gnome bindings maintainers
java-gnome bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-30 14:19 UTC by Igor Foox
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
First draft of a fix (5.00 KB, patch)
2005-09-30 14:31 UTC, Igor Foox
none Details | Review
Second version (5.00 KB, patch)
2005-09-30 14:44 UTC, Igor Foox
none Details | Review
Third time's the charm (5.44 KB, patch)
2005-09-30 19:32 UTC, Igor Foox
none Details | Review

Description Igor Foox 2005-09-30 14:19:04 UTC
Distribution/Version: Fedora Core 4

libvte-java works with Java-GNOME 2.6/2.10 but doesn't work with 2.8/2.12. There
have also been memory management changes that need to be incorporated into it.
Comment 1 Igor Foox 2005-09-30 14:31:43 UTC
Created attachment 52855 [details] [review]
First draft of a fix

I fixed up the memory management stuff by replacing getHandleFromPointer by
getGObjectHandle, it turned out there were only 3 references to
getHandleFromPointer.

I also fixed up some of the build stuff, such as adding the macros checking for
glib-java, and also changed the jg-jnu.h header location. I also made
configure.ac use pkg-config to look for the location of macros for glib-java
and gtk2, it was only looking in standard places, which breaks the build on
machines with non-standard package locations.
Comment 2 Igor Foox 2005-09-30 14:44:44 UTC
Created attachment 52856 [details] [review]
Second version

Fixed up some problems from previous patch. Made libvte-java require gtk-java
2.8. Also changed a getGObjectHandle to getGBoxedHandle.
Comment 3 Igor Foox 2005-09-30 19:32:23 UTC
Created attachment 52884 [details] [review]
Third time's the charm

Added the extra options required by getGBoxedHandle. Added the build-dir to the
lookup path of .java files for java-doc generation, this was a problem when
building out-of-tree, since the src dir only contained a .java.in, and javadoc
would not take it.

Igor
Comment 4 Igor Foox 2005-09-30 20:00:51 UTC
Commited.