After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 305551 - Missing g_free in nautilus-window-menus.ci
Missing g_free in nautilus-window-menus.ci
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.11.x
Other All
: High minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-05-26 13:59 UTC by Brian Pepple
Modified: 2005-05-26 19:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch adding the missing g_free (). (487 bytes, patch)
2005-05-26 14:00 UTC, Brian Pepple
needs-work Details | Review
Added suggestions from Chrisitan (1.11 KB, patch)
2005-05-26 15:34 UTC, Brian Pepple
committed Details | Review

Description Brian Pepple 2005-05-26 13:59:31 UTC
action_about_nautilus_callback () is missing a g_free () after using g_strconcat
() for a variable.
Comment 1 Brian Pepple 2005-05-26 14:00:09 UTC
Created attachment 46904 [details] [review]
Patch adding the missing g_free ().
Comment 2 Christian Neumair 2005-05-26 14:09:24 UTC
Thanks for your bug report!
This also seems to affect logo_path. Also, you may want to move the
license_trans initialization/free code into the if code block.
Comment 3 Brian Pepple 2005-05-26 15:34:41 UTC
Created attachment 46908 [details] [review]
Added suggestions from Chrisitan

Move license_tran initialization/free code into the if code block, and free
logo_path.
Comment 4 Kjartan Maraas 2005-05-26 18:53:40 UTC
Is this relevant for the gnome-2-10 branch as well?
Comment 5 Christian Neumair 2005-05-26 19:11:32 UTC
From IRC:
<campd> Manny: looks good

Kjartan: It used to be :D.
Brian: Thanks a lot for your efforts. The upcoming 2.10 and 2.11 releases will
contain your fix.