GNOME Bugzilla – Bug 172168
Get FG/BG colors from gnome theme
Last modified: 2006-06-14 08:07:43 UTC
Xchat-gnome does a great job of blending in to the feel of the gnome desktop, but it would be doubly pretty if it had the option (possibly as a default setting) of getting its fg and bg colors from the current gnome theme, just like gnome-terminal's "Use colors from system theme" option. These colors would be reliable as not only matching the look of the rest of the desktop, but also having a contrast level equal to that of the theme, so high-contrast themes or themes designed to improve visibility for users with specific color sensitivities would be mirrored in xchat-gnome.
Created attachment 67157 [details] [review] Implementation of gnome system colors for xchat text Attached patch: - adds "System Colors" to the built-in color scheme list - extracts theme colors for use - guesses whether you want to use the black-on-white or white-on-black palette when using your automatically determined color scheme - updates color scheme on theme change - fixes the order of the palette schemes
Accepted with a few changes. In future, you just need a single ChangeLog entry, since it's mostly useful for distro packagers backporting changes. Your swap of the palette tables caused the palettes to be swapped, since the root cause of the problem was incorrect names. In addition, I made "system colors" the 4th entry in the list rather than the first and updated the gconf schema, so that people won't suddenly have their color scheme change out from under them when they upgrade.