After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171218 - 'Browse Network' closes the 'Connect the Server' dialog
'Browse Network' closes the 'Connect the Server' dialog
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: general
2.13.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-03-22 14:06 UTC by Kaushal Kumar
Modified: 2010-07-04 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is not the fix. Just a work in progress. (1.22 KB, patch)
2005-09-14 10:23 UTC, Kaushal Kumar
none Details | Review

Description Kaushal Kumar 2005-03-22 14:06:20 UTC
The 'Browse Network' button in the 'Connect to Server' dialog destroys the dialog.

This may not be the right behavior since a user might want to browse the network
and then connect to some server.

From usability point of view, if 'Browse Network' is part of 'Connect to Server'
dialog without any functional dependency, then it could be provided as the File
menu item seperately.

Other information:
Comment 1 Kaushal Kumar 2005-03-22 14:21:35 UTC
I modified the 'Browse Network' callback to prevent the dialog from getting
destroyed. However, I found another problem there. The 'Connect to Server'
dialog always remains on top of other nautilus windows. So, the Network Folder
is obscured by it and would not come on top.

This problem does not occur with the Places->'Connect to Server' option from
panel. IMO, the reason is: this is invoked as a seperate process and thus the
stacking is not affected.

I am trying to find out how the Preferences dialog is doing it correctly. They
are similar as in they both exist as nautilus spawns, as well as binaries.
Comment 2 Christian Neumair 2005-09-03 22:57:05 UTC
Kaushal: You should add
  gdk_window_set_group (GTK_WIDGET (window)->window, GTK_WIDGET (window)->window);
in src/nautilus-connect-server-dialog.c:nautilus_connect_server_dialog_new
inside the if (window) branch.
Comment 3 Kaushal Kumar 2005-09-14 10:23:14 UTC
Created attachment 52217 [details] [review]
This is not the fix. Just a work in progress.

Christian,
Thanks for your response and putting in a suggestion.
I tried it out, but somehow it does not work in the expected manner. I have
attached the diff for your second look, as I am still missing out on something.
Comment 4 Christian Neumair 2005-09-14 14:27:58 UTC
The patch looks nice and partially works for me. The issue seems to be that
metacity associates the newly created "network:///" window to the currently open
"Connect to Server" dialog.

This could vanish by resolving bug 116004.
Comment 5 Christian Neumair 2005-10-03 12:28:13 UTC
Mass changing Nautilus version for bugs that have GNOME 2.13 version info.
Comment 6 Karderio 2006-01-17 19:48:34 UTC
I would vote to remove the remove the 'Browse Network' button, this is available from many other places, plus personally I find it rather inconsistent behavior (I have seen this sort of shortcut button nowhere else).

I would like to add a help button to the 'Connect to Server' dialog, removing the button would leave some space for this also :-)

Could I please have some feedback, who thinks the button should stay, who would have it go, can I add a help button next to it ?

Love Karderio
Comment 7 Colin Watson 2008-07-29 11:09:06 UTC
The button seems to have been removed (http://svn.gnome.org/viewvc/nautilus/trunk/src/nautilus-connect-server-dialog.c?r1=13479&r2=13797). That said, this attracted objections in http://www.arsgeek.org/2008/05/31/six-annoyances-in-hardy-heron-ubuntu/, saying: "I guess you need to know the exact name of the Samba or Windows share that you want to connect to? If so, that’s pretty annoying. It’s also inconsistent, because when I tried to add a printer on a remote machine, I could browse the network from the printer dialog box."
Comment 8 A. Walton 2009-01-07 16:52:46 UTC
Patch no longer applies. Setting status.
Comment 9 Marcus Carlson 2010-07-04 21:30:06 UTC
As the button to browse the network has been removed - could we close this bug?
Comment 10 Cosimo Cecchi 2010-07-04 23:19:15 UTC
Yeah, this is obsolete.