After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 158967 - [PATCH] Alert Dialog and Tooltip cleanup
[PATCH] Alert Dialog and Tooltip cleanup
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cpufreq
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-11-21 19:25 UTC by Dennis Cranston
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Example of error dialog before change. (20.38 KB, image/png)
2004-11-21 19:26 UTC, Dennis Cranston
  Details
Example of error dialog after change. (11.61 KB, image/png)
2004-11-21 19:27 UTC, Dennis Cranston
  Details
Example of error dialog after change. (12.71 KB, image/png)
2004-11-21 19:28 UTC, Dennis Cranston
  Details
Example of tooltip after change. (7.06 KB, image/png)
2004-11-21 19:28 UTC, Dennis Cranston
  Details
Proposed patch. (5.47 KB, patch)
2004-11-21 19:29 UTC, Dennis Cranston
none Details | Review
Proposed patch. (5.51 KB, patch)
2004-11-21 21:16 UTC, Dennis Cranston
none Details | Review
Updated patch. (5.67 KB, patch)
2004-11-28 19:12 UTC, Dennis Cranston
none Details | Review

Description Dennis Cranston 2004-11-21 19:25:18 UTC
I am attaching a patch to HIGify the alert dialogs.  This means supporting
primary and secondary message text in the dialogs.  I also cleaned up the
applet's tooltip text.
Comment 1 Dennis Cranston 2004-11-21 19:26:31 UTC
Created attachment 33991 [details]
Example of error dialog before change.
Comment 2 Dennis Cranston 2004-11-21 19:27:08 UTC
Created attachment 33992 [details]
Example of error dialog after change.
Comment 3 Dennis Cranston 2004-11-21 19:28:07 UTC
Created attachment 33993 [details]
Example of error dialog after change.
Comment 4 Dennis Cranston 2004-11-21 19:28:48 UTC
Created attachment 33994 [details]
Example of tooltip after change.
Comment 5 Dennis Cranston 2004-11-21 19:29:22 UTC
Created attachment 33995 [details] [review]
Proposed patch.
Comment 6 Dennis Cranston 2004-11-21 21:16:00 UTC
I missing one thing.  
The alerts dialog should use an 'OK' button, not a 'Close' button.
Comment 7 Dennis Cranston 2004-11-21 21:16:33 UTC
Created attachment 34000 [details] [review]
Proposed patch.
Comment 8 Danielle Madeley 2004-11-25 15:18:48 UTC
Dennis, some thoughs:

 - attachment 33992 [details] - there should probably be a little more description, I think
   something like:
         CPU Frequency Scaling Unsupported
           You will not be able to modify the
           frequency of your machine. Your machine
           may be misconfigured or not have hardware
           support for CPU Frequency Scaling.

Also, we need to make a decision for consistancy about how to name it, Frequency
Scaling, Frequency monitoring, Computer Speed Scaling. Something descriptive and
simple.

Carlos, thoughts?
Comment 9 Carlos Garcia Campos 2004-11-25 16:54:27 UTC
In this dialog we want to notify that there isn't CPU Frequency Scaling support
in the current kernel or system, so I think it should be CPU Frequency Scaling,
not monitoring. But there could be several reasons why the cpufreq is not
working, maybe it's compiled in the kernel but the /sys fielsystem is not
mounted. The dialog should try to explain this situation to the user, but in a
user friendly way (I know it's  not so easy). I like the davyd suggestion.
Comment 10 Dennis Cranston 2004-11-26 19:05:03 UTC
I agree with Davyd's wording for the dialog, and I'll rework the patch to use
the term CPU Frequency Scaling.  Thanks for the feedback.
Comment 11 Dennis Cranston 2004-11-28 19:12:34 UTC
Created attachment 34239 [details] [review]
Updated patch.

This patch uses the term 'scaling' rather than 'montor', and rewords the error
dialog as discussed above.
Comment 12 Carlos Garcia Campos 2004-11-30 16:59:28 UTC
Applied in CVS. Thank you again ;-)
Comment 13 Danielle Madeley 2004-12-20 09:55:43 UTC
Can this bug be closed?
Comment 14 Carlos Garcia Campos 2004-12-20 10:39:30 UTC
Yes, I haven't closed it yet because I haven't permission
Comment 15 Danielle Madeley 2004-12-20 10:45:00 UTC
To close bugs?
Comment 16 Carlos Garcia Campos 2004-12-20 11:51:43 UTC
Yes, I only have the "Leave as . . ." option in all of the bugs.
Comment 17 Danielle Madeley 2004-12-20 13:05:14 UTC
Hmm, ask for more permissons in #bugs