After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 156332 - Faulty window resize when showing controls
Faulty window resize when showing controls
Status: RESOLVED WONTFIX
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 172984 433821 668414 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-10-24 22:00 UTC by catkfr
Modified: 2013-02-22 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description catkfr 2004-10-24 22:00:30 UTC
1. play movie
2. hide controls
3. show controls --> window resized and made wider
4. goto 2. and continue to make window wider

This bug is new to version 0.99.15 (previously did not have this with 0.99.8)
Comment 1 Bastien Nocera 2004-10-25 09:17:27 UTC
This should already be fixed in CVS.

2004-10-21  Bastien Nocera  <hadess@hadess.net>
                                                                                
        * src/totem-playlist.c: (totem_playlist_add_files),
        (totem_playlist_save_files):
        * src/totem.c: (on_open1_activate), (show_controls):
        for all the file selectors, use gtk_file_chooser_set_current_folder_uri
        instead of gtk_file_chooser_set_uri (Closes: #156030)
        When hiding and showing the controls again, don't shrink the window
Comment 2 Philip Withnall 2007-04-28 16:52:16 UTC
*** Bug 433821 has been marked as a duplicate of this bug. ***
Comment 3 Philip Withnall 2007-04-28 16:53:32 UTC
This has regressed on trunk, and per bug #433821.
Comment 4 Philip Withnall 2007-04-28 17:25:33 UTC
On trunk, I get the following when doing this repeatedly:

(totem:2702): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -11 and height 109

(totem:2702): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -11 and height 86

(totem:2702): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -11 and height 86
Comment 5 Adrien Bustany 2008-01-01 20:01:32 UTC
I can't reproduce this with 2.20.1
I play a video, press H several times (show/hide controls) and nothing happens in the log.
Comment 6 Philip Withnall 2008-01-04 11:38:46 UTC
Pressing H several times seems to work, but I can still trigger it on trunk if I hold down H for a few seconds.
Comment 7 Philip Withnall 2008-01-04 12:34:10 UTC
I can consistently produce it with http://tecnocode.co.uk/AlmostTerribleWorkDa.avi. Looking at a stack trace from running with --g-fatal-warnings, the widget which fails size allocation is "general", a GtkTable in properties.ui.
Comment 8 Bastien Nocera 2008-03-20 13:51:05 UTC
*** Bug 172984 has been marked as a duplicate of this bug. ***
Comment 9 Bastien Nocera 2011-04-08 02:35:55 UTC
This is mostly fixed in GNOME 3.0, though you'll still get some weirdness when leaving "H" pressed. But it doesn't warn anymore, and it only goes absolutely bananas when the sidebar is shown.
Comment 10 Bastien Nocera 2012-04-18 16:52:59 UTC
*** Bug 668414 has been marked as a duplicate of this bug. ***
Comment 11 mgsk 2012-12-19 09:37:51 UTC
This is *still* a problem. Showing and then hiding controls leads to a reduction in video size. This is not, IMO, expected behaviour. Is it so hard to fix?
Comment 12 Bastien Nocera 2012-12-19 09:44:10 UTC
(In reply to comment #11)
> Is it so hard to fix?

It is, why don't you try it?
Comment 13 mgsk 2012-12-19 10:12:52 UTC
> It is, why don't you try it?

Ah! the refrain of Free Software!

Why don't I try it? If I was a Totem developer I surely would; but perhaps if I was a Totem developer I would've also developed the same attitude as yourself and be content with Not Fixing Things.

Controls are shown? Note video dimensions. Controls are hidden? Resume previous dimensions.
Comment 14 Bastien Nocera 2012-12-19 10:15:15 UTC
(In reply to comment #13)
> > It is, why don't you try it?
> 
> Ah! the refrain of Free Software!

No, it's the refrain for bug commenters that think things are easy to fix but don't get their hands dirty.

> Why don't I try it? If I was a Totem developer I surely would; but perhaps if I
> was a Totem developer I would've also developed the same attitude as yourself
> and be content with Not Fixing Things.
> 
> Controls are shown? Note video dimensions. Controls are hidden? Resume previous
> dimensions.

If it was that easy, it would have been fixed already. It's not.
Comment 15 mgsk 2012-12-19 10:40:45 UTC
> No, it's the refrain for bug commenters that think things are easy to fix but
don't get their hands dirty.

You're pathetic.
Comment 16 Bastien Nocera 2012-12-19 10:49:25 UTC
(In reply to comment #15)
> > No, it's the refrain for bug commenters that think things are easy to fix but
> don't get their hands dirty.
> 
> You're pathetic.

That's really helping.
Comment 17 Bastien Nocera 2013-02-22 12:12:26 UTC
This will not be part of the new design:
https://live.gnome.org/Design/Apps/Videos#Tentative_Design