GNOME Bugzilla – Bug 147999
The clock baseline is slightly off
Last modified: 2004-09-28 15:55:44 UTC
Add several textual applets to a panel and compare their baselines
Created attachment 29693 [details] Screenshot Example
*** Bug 149355 has been marked as a duplicate of this bug. ***
It seems it appeared between 2.6.0 and 2.6.2. Could this be because of this commit: 2004-06-02 Mark McLoughlin <mark@skynet.ie> Fix for bug #138881 - clock takes up too much width when you resize the panel such that the clock displays on two rows. * clock.c: (applet_change_orient), (applet_change_pixel_size): unfix the cached size when the orientation or size changes.
This is also the case for the "Inbox Monitor"
Mmmh, the fix for bug 138881 did not create this bug (I've unapplied the patch and the bug is still here). This is especially annoying when the clock label gets cropped because of the offset.
Created attachment 30401 [details] screenshot showing the cropped label
This feels like it's related to some change in gtk+...
This bug affects all applets that insert a GtkButton on the panel (ie the clock applet, charpick applet, dictionary applet...) when the panel is < 24. I will attach a screenshot soon. The window list applet does not seem affected by this.
Created attachment 30409 [details] screenshot showing the crop
The change in question is that the button is actually reserving space for the focus rectangle now, and doesn't simply draw it over the child widget anymore.
So do you think this is fixable, or WONTFIX ? Should it be fixed in the panel or on the gtk+ level ? It affects many applets for a panel size <= 24 (which is very common...)
note: if you resize the panel from 12 to 13 pixels you can actually see the whole text of the clock and mail applets. yey. It doesn't fix the baseline being off, but it solves the "I cant read it properly" issue.
Okay, so we've always made it so that anything on the panel should try its best to ignore focus-line-width/focus-padding and draw the focus indication over child widgets since space is so tight on the panel. I've just committed a hacky patch to force no focus padding for the applet. Attaching here so that people can use the same hack to "fix" other applets and so that Matthias can shout at me :-)
Created attachment 31986 [details] [review] As _v_ would say - "EEEEEEEEEEEEEEEEEK ... HACK!"
Point: the same bug exists in the mailchecker applet, can you please fix that too?
I have created a new bug against gnome-applets (bug 153971). I'll try to come up with a few patches soon for the remaining applets.