After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 147999 - The clock baseline is slightly off
The clock baseline is slightly off
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.6.x
Other Linux
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 149355 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-07-20 15:17 UTC by Nicolas Mailhot
Modified: 2004-09-28 15:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
Screenshot (3.55 KB, image/png)
2004-07-20 15:20 UTC, Nicolas Mailhot
  Details
screenshot showing the cropped label (7.61 KB, image/png)
2004-08-10 17:11 UTC, Vincent Noel
  Details
screenshot showing the crop (9.09 KB, image/png)
2004-08-10 18:59 UTC, Vincent Noel
  Details
As _v_ would say - "EEEEEEEEEEEEEEEEEK ... HACK!" (2.14 KB, patch)
2004-09-27 16:21 UTC, Mark McLoughlin
none Details | Review

Description Nicolas Mailhot 2004-07-20 15:17:21 UTC
Add several textual applets to a panel and compare their baselines
Comment 1 Nicolas Mailhot 2004-07-20 15:20:40 UTC
Created attachment 29693 [details]
Screenshot

Example
Comment 2 Vincent Untz 2004-08-05 08:11:52 UTC
*** Bug 149355 has been marked as a duplicate of this bug. ***
Comment 3 Vincent Untz 2004-08-05 08:12:46 UTC
It seems it appeared between 2.6.0 and 2.6.2. Could this be because of this commit:

2004-06-02  Mark McLoughlin  <mark@skynet.ie>

	Fix for bug #138881 - clock takes up too much width when
	you resize the panel such that the clock displays on
	two rows.

	* clock.c:
	(applet_change_orient), (applet_change_pixel_size): unfix
	the cached size when the orientation or size changes.
Comment 4 D.S. (Spider) Ljungmark 2004-08-06 15:52:15 UTC
This is also the case for the "Inbox Monitor"
Comment 5 Vincent Noel 2004-08-10 17:10:39 UTC
Mmmh, the fix for bug 138881 did not create this bug (I've unapplied the patch
and  the bug is still here). This is especially annoying when the clock label
gets cropped because of the offset.
Comment 6 Vincent Noel 2004-08-10 17:11:58 UTC
Created attachment 30401 [details]
screenshot showing the cropped label
Comment 7 Vincent Noel 2004-08-10 17:48:49 UTC
This feels like it's related to some change in gtk+...
Comment 8 Vincent Noel 2004-08-10 18:59:12 UTC
This bug affects all applets that insert a GtkButton on the panel (ie the clock
applet, charpick applet, dictionary applet...) when the panel is < 24. I will
attach a screenshot soon.
The window list applet does not seem affected by this.
Comment 9 Vincent Noel 2004-08-10 18:59:37 UTC
Created attachment 30409 [details]
screenshot showing the crop
Comment 10 Matthias Clasen 2004-09-22 06:02:16 UTC
The change in question is that the button is actually reserving space for the
focus rectangle now, and doesn't simply draw it over the child widget anymore.
Comment 11 Vincent Noel 2004-09-22 14:04:03 UTC
So do you think this is fixable, or WONTFIX ? Should it be fixed in the panel or
on the gtk+ level ?

It affects many applets for a panel size <= 24 (which is very common...)
Comment 12 D.S. (Spider) Ljungmark 2004-09-22 15:44:06 UTC
note: if you resize the panel from 12 to 13 pixels you can actually see the
whole text of the clock and mail applets. yey.  It doesn't fix the baseline
being off, but it solves the "I cant read it properly" issue.
Comment 13 Mark McLoughlin 2004-09-27 16:19:57 UTC
Okay, so we've always made it so that anything on the panel should try its best
to ignore focus-line-width/focus-padding and draw the focus indication over
child widgets since space is so tight on the panel.

I've just committed a hacky patch to force no focus padding for the applet.
Attaching here so that people can use the same hack to "fix" other applets and
so that Matthias can shout at me :-)
Comment 14 Mark McLoughlin 2004-09-27 16:21:16 UTC
Created attachment 31986 [details] [review]
As _v_ would say - "EEEEEEEEEEEEEEEEEK ... HACK!"
Comment 15 D.S. (Spider) Ljungmark 2004-09-27 18:32:30 UTC
Point:
the same bug exists in the mailchecker applet, can you please fix that too?
Comment 16 Vincent Noel 2004-09-28 15:55:44 UTC
I have created a new bug against gnome-applets (bug 153971). I'll try to come up
with a few patches soon for the remaining applets.