After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 142934 - Add Delete control to Slideshow Controls
Add Delete control to Slideshow Controls
Status: RESOLVED WONTFIX
Product: gthumb
Classification: Other
Component: general
2.3.x
Other Linux
: High enhancement
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2004-05-21 21:05 UTC by Thomas Lunde
Modified: 2005-01-12 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This attachment contains a patch that adds Delete button to slideshow controls. (1.99 KB, patch)
2005-01-07 10:59 UTC, Naveen Chandran V
none Details | Review
The Updated Patch (1.95 KB, patch)
2005-01-10 16:09 UTC, Naveen Chandran V
none Details | Review

Description Thomas Lunde 2004-05-21 21:05:26 UTC
Select a number of images.  Click on the Slide Show button.  Move the mouse. 
Now, a small number of slideshow controls will appear:  "Restore Normal View",
"Image Info", "Back" and "Forward".

Please add a "Delete" control.  Allow this control to be activated by both an
on-screen button and the Delete key on my keyboard.

When I am reviewing new images from my digital camera, it is nice to be able to
quickly see a slideshow of them and review them quickly.  When I encounter one
that is obviously bad (e.g. out of focus), it would be nice to be able to
immediately delete that image.

In the Preferences pane, there is a checkbox for confirmation of image deletion.
   If that preference is turned off, then the image should be immediately
deleted and the next one in the slide show displayed.  (If it is the last image
and "Restart When Finished" is turned off in the Preferences, the previous image
should be re-displayed.)  

If that image deletion confirmation preference is turned on, then the slide show
should be automatically paused (see Bug # 142933) and a dialog box displayed
which seeks the confirmation.  After the dialog is dismissed, the slide show
would automatically unpause and continue as before.
Comment 1 Thomas Lunde 2004-05-21 22:25:11 UTC
Oops.  I just found the keystroke page in the help and I see that Del already
does this.  Perhaps the menu Edit -> Move to Trash could have Del listed on the
right as some (but not all, apparently) of the keystroke shortcuts are.

Also, I'd urge that the Backspace be made the same as the Del key instead of the
"Back" key.  Many laptops have a Backspace key on them, but require a keystroke
combination (say, Fn plus Backspace) to select a "Del" key.
Comment 2 Naveen Chandran V 2005-01-07 10:59:53 UTC
Created attachment 35600 [details] [review]
This attachment contains a patch that adds Delete button to slideshow controls.

This patch adds Delete button to slideshow controls.
Comment 3 Naveen Chandran V 2005-01-10 16:09:45 UTC
Created attachment 35789 [details] [review]
The Updated Patch
Comment 4 Paolo Bacchilega 2005-01-12 18:13:04 UTC
thanks for the patch, however I think that toolbars should list the most common
commands only, and deleting images is not a common operation when in fullscreen
mode, I think that making it available through the "Delete" key it's enough.
Comment 5 Thomas Lunde 2005-01-12 18:51:48 UTC
Paolo -

Please reconsider the decision not to include this patch.

When I import a bunch of images from my camera, the first thing I do (and many people do, I think) is 
to view a quick slideshow.  It would be really great if I could immediately delete the bad pictures on this 
first viewing pass.

Without a delete button, I have to manually keep track of which files I want to kill and then remove 
them after the slideshow.  While it might sound easy to pick out the "right" (bad) pictures just from the 
thumbnail view it is often not:  if I take a couple of different pictures of a scene, I really need to see 
them at full screen to see which is the best (so I can delete the rest).  As another example, if you take a 
picture of a group of people, it is a good practice to take a couple of images because at least one 
person invariably has their eyes closed.  There is simply _no_way_ to spot this detail with a thumbnail 
view, so I'm forced back into the pattern of full screen for the two or three (or more) shots and trying to 
remember the correct filename to keep.

I suggested this feature after using iPhoto on my girlfriend's mac; it was really handy there to be able to 
delete the bad photos during the first slideshow after the import.

If you don't want the control on every slide show, perhaps a set of preferences checkboxes for the user 
to select from for which controls to have available for slideshows (back, forward, end, delete, pause, 
ratings, etc.)

Thank you for your consideration.

thomas
Comment 6 Paolo Bacchilega 2005-01-12 21:34:22 UTC
you CAN delete images in fullscreen mode, just press the delete key.