GNOME Bugzilla – Bug 141793
gnome-settings-daemon keeps occupying alsa (GST backend)
Last modified: 2004-12-22 21:47:04 UTC
gnome-settings-daemon keeps occupying /dev/snd/controlC0 so restarting alsa after a laptop suspend is not possible. i expected it would act as gnome-2.4 where that file was not occupied all the time. i used the gentoo's gnome-2.6_p1.ebuild to build it using CFLAGS="-march=pentium3 -O3 -pipe" CHOST="i686-pc-linux-gnu" Keep up the good work !!! (i hate myself for not being a programmer)
Hi, The same problem has also been reported on Debian BTS : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=255793&repeatmerged=no
2004-07-15 Bastien Nocera <hadess@hadess.net> * actions/acme-volume-alsa.c: (acme_volume_alsa_finalize), (acme_volume_alsa_set_mute), (acme_volume_alsa_get_mute), (acme_volume_alsa_get_volume), (acme_volume_alsa_set_volume), (acme_volume_alsa_close_real), (acme_volume_alsa_open), (acme_volume_alsa_close), (acme_volume_alsa_init): rework the ALSA mixer so that: - the ALSA device isn't kept open at all times, only for 4 seconds after the last use (Closes: #141793) - the hardware mute is used if it is available (Closes: #141404, #144489, #140937) - lowering the volume doesn't move the balance to the right - it doesn't leak alsa-lib mixers all around
This bug is still there as you fixed the code that handle directly alsa. The gstreamer code needs also to be fixed (as it's possible to use alsa with gstreamer).
Created attachment 30511 [details] [review] patch to free alsa with gstreamer
*** Bug 155678 has been marked as a duplicate of this bug. ***
the gstreamer part of the patch is used in the debian package and seems to work fine, permission to commit to HEAD ?
The patch doesn't apply to HEAD any more. Arnaud, could you update the patch to fit on either HEAD or gnome-2-8?
Created attachment 34328 [details] [review] updated patch oups, I was supposed to do that. This patch is the version currently used in the Debian package, I'll commit it now.
commit to gnome-2-8 and HEAD
This breaks acme for me
Created attachment 34666 [details] [review] patch which fixes the problem The attached patch fixes the problem. - return FALSE; + return TRUE; is what fixes it, I dunno if it's correct though. The acme_volume_gstreamer_open function clearly has an issue though since it does a lot of stuff, but unconditionnally return FALSE as if it had failed. The rest of the patch cleans up some warnings when gnome-settings-daemon is run from a terminal.
Created attachment 34667 [details] [review] should be more correct
Fixed in HEAD and gnome-2-8