After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 140126 - the file chooser does not deal with comments in text/uri-list
the file chooser does not deal with comments in text/uri-list
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.4.x
Other All
: Normal minor
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2004-04-15 06:55 UTC by Mariano Suárez-Alvarez
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
make gtkfilechooserdefault.c:shortcuts_drop_uris ignore comments (639 bytes, patch)
2004-04-15 06:59 UTC, Mariano Suárez-Alvarez
none Details | Review

Description Mariano Suárez-Alvarez 2004-04-15 06:55:00 UTC
RFC 2483 states that lines that start with # should be ignored in text/uri-list
objects.
Comment 1 Mariano Suárez-Alvarez 2004-04-15 06:59:55 UTC
Created attachment 26677 [details] [review]
make gtkfilechooserdefault.c:shortcuts_drop_uris  ignore comments
Comment 2 Federico Mena Quintero 2004-04-15 17:56:57 UTC
Thanks for the patch!  I'll apply it in a bit.
Comment 3 Federico Mena Quintero 2004-04-15 19:18:49 UTC
Fixed on CVS with a different patch.  Your patch fixed the symptom, not the
cause --- it is split_uris() who should take out commented lines, not the
caller, as that lets us make it public later.