GNOME Bugzilla – Bug 138582
[Patch] Running gnome-sound-recorder without GStreamer registry causes crash
Last modified: 2005-04-17 01:19:14 UTC
Distribution: Unknown Package: gnome-media Severity: normal Version: GNOME2.5.92 2.5.5 Gnome-Distributor: GNOME.Org Synopsis: Running gnome-sound-recorder without GStreamer registry causes crash Bugzilla-Product: gnome-media Bugzilla-Component: Gnome-Sound-Recorder Bugzilla-Version: 2.5.5 BugBuddy-GnomeVersion: 2.0 (2.5.92) Description: Description of the crash: Error dialog appears Steps to reproduce the crash: 1. Don't run gst-register after installing GStreamer 2. Launch Sound Recorder 3. Expected Results: Message explaining that there's no (or out-of-date) GStreamer registry How often does this happen? Each time Additional Information: Debugging Information: Backtrace was generated from '/usr/bin/gnome-sound-recorder' [New Thread 1024 (LWP 1889)] 0x40d1e409 in wait4 () from /lib/libc.so.6
+ Trace 45542
Thread 1 (Thread 1024 (LWP 1889))
------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-03-30 22:34 ------- Unknown version 2.5.5 in product gnome-media. Setting version to "1.112.0". Unknown platform unknown. Setting to default platform "Other". Unknown milestone "unknown" in product "gnome-media". Setting to default milestone for this product, '---' Setting to default status "UNCONFIRMED". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Has this been addressed in gstreamer or does it need to be fixed in every app?
g-s-r is using gnome_program_init with a pointer to gst's popt table. I'll check into how with this setup it can be made to not assert. I'm pretty sure though that gtk does the same thing if it cannot initialize.
*** Bug 150595 has been marked as a duplicate of this bug. ***
*** Bug 146068 has been marked as a duplicate of this bug. ***
*** Bug 154613 has been marked as a duplicate of this bug. ***
no gstreamer registry means broken gstreamer installation, no ?
Yeah, it means it's broken, but maybe the user should get some feedback and a message to run gst-register-0.x instead of the app just crashing.
I don't know of a single distribution that doesn't run gst-register automatically... I suppose you're right, but current versions just g_error()...
SuSE 9.1 doesn't run gst-register automatically (or didn't when I installed it). It's still avoiding the point - a program should never crash - would it be too hard to bring up an error dialogue stating "gst-register isn't running"?
I'll try to get a proper change in. It's not so much hard, as much as we're just used to the current behaviour. Might be wrong, but it's legacy...
Created attachment 36436 [details] Patch for this problem Ronald, Patch as per your suggestions on IRC. Thanks.
Created attachment 36437 [details] [review] Patch against head sources
Go ahead and apply (you have GNOME CVS access, right?). While you're at it, can you apply the very same patch to gnome-volume-control and gnome-cd? They use GStreamer as well. The patch would be exactly the same. :).
Thanks Ronald. Did the same changes to gnome-cd and gnome-volume-control. Marking this bug as fixed. For gnome-cd I have put this check under #ifdef HAVE_GST. Thanks
Created attachment 36449 [details] [review] Final patch that I checked in
Good work, thanks Bala. I'll add this to the manual, too, at some point.
*** Bug 166545 has been marked as a duplicate of this bug. ***
*** Bug 300846 has been marked as a duplicate of this bug. ***