GNOME Bugzilla – Bug 137800
Default status msg.
Last modified: 2006-07-29 23:31:44 UTC
can U add option to select default status on startup (with my own status messages)
Should be fairly easy for someone to write a patch for this, it's low priority to me though.
Created attachment 69003 [details] [review] First attempt to fix this bug I know this patch is not complete, but I would like to know if I'm on the right way. It was made using the latest CVS version. TODO: -Create the needed keys and their default values in gconf during the installation.
Created attachment 69504 [details] [review] Second attempt This new patch fixes the following things: -Creates the needed keys if they don't exist -Use gossip_conf_get() and gossip_conf_set() instead of gconf's ones. -Change the constants and function names according to the latest CVS version It was made using cvs diff -u against today's CVS version.
Hi, OK, you're not going to like this, but: I don't think this is actually very useful. What is useful is remembering the last status message used and setting your presence to that when connecting. This is good for ad-hoc networks and people that are perhaps not on very stable connections. Putting a presence chooser in the preferences is just wrong sorry. Also, for the future, you need to add new gconf paths to the schema that gets installed (gossip.schema.in). The status presets are not saved in gconf, they are in an XML file: $HOME/.gnome2/Gossip/status-presets.xml and I have simply added to that because no status information is in gconf. For the moment, we are using gconf for quick simple UI information like "Show offline contacts". I actually did this work completely from scratch because it was easier. But thanks for the patch, it prompted me to do it :) If you ever (and you might not after this) want to do future patches for gossip, I recommend you check how we want things implemented before putting a lot of time into a patch. Thanks all the same.
> If you ever (and you might not after this) want to do future patches for > gossip, I recommend you check how we want things implemented before putting a > lot of time into a patch. Thanks for the advice. I was keen to help and I didn't ask first how to do it. > If you ever (and you might not after this) want to do future patches for > gossip, I recommend you check how we want things implemented before putting a > lot of time into a patch. I still want to do patches for gossip. It was my first gnome-love patch, so I knew it wouldn't be accepted :-) Thanks for the patch's review.