After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 134950 - force load as default
force load as default
Status: RESOLVED FIXED
Product: conglomerate
Classification: Other
Component: Code
unspecified
Other All
: Normal normal
: 0.8.0
Assigned To: conglomerate list
conglomerate list
Depends on:
Blocks:
 
 
Reported: 2004-02-20 10:08 UTC by Geert Stappers
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Contains a patch with ChangeLog (8.47 KB, patch)
2004-04-29 08:34 UTC, Nickolay V. Shmyrev 		committed Details | Review

Description Geert Stappers 2004-02-20 10:08:46 UTC 
( from the mailinglist discussion "What is Conglomerate?" )

>
> Thing that anonies me,
> is that the userfriendy XML editor assumes stupid users.
>
> Example:
>
>  Open a document that has not a DTD,
>  then there is warning dialog with a default on abort.
>
> The user wants to open the file, make the default on 'force load'
                                                                          
     
Yeah, please file that as a bug in the dialog, probably should be:
                                                                          
     
        (some rewritten warning text goes here)
                        [Cancel] [Ok]
Comment 1 Geert Stappers 2004-02-20 10:17:17 UTC 
AFAICT the code is in src/cong-file-open.c

Marking it for 0.8.0, because we should assume smart users from the
begining.
Comment 2 Nickolay V. Shmyrev 2004-04-28 21:47:18 UTC 
I've looked through code to see, where is corresponding function 

cong_error_dialog_new_with_convenience()

is used. It is used in three cases

1. Force (when there is no DTD)
2. Search (when there is no file on file open)
3. Details (when some error on processing xml)

In first case the default on forse is usable, in other cases, I think, the
default should be abort.

So the question is, should we correct function, or only particular case, when
force document loading is needed.
Comment 3 Nickolay V. Shmyrev 2004-04-28 22:07:08 UTC 
Also, the presence OK button in dialog leads to misunderstanding, since OK
really means Cancel.
Comment 4 Nickolay V. Shmyrev 2004-04-28 23:35:15 UTC 
Note, that there are also problems with memory leak (data passed to callback
can't be clearly freed).
Comment 5 Nickolay V. Shmyrev 2004-04-29 08:34:08 UTC 
Created attachment 27197 [details] [review]
Contains a patch with ChangeLog

Added 2 new parameter to function 

cong_error_dialog_new_with_convenience 

first will be the stock of other button, second will be the boolean value, that

determine, is the convenience button will be default.

Updated use of this functions.

Also, made a little rewrote of function - now it is support gtk stock for
convenience label and improve HIG compiliance.
Comment 6 Geert Stappers 2004-04-29 20:53:02 UTC 
Patch is applied into the 'withoutdave' branch.

(I have on "wrong file" at hand to check the behaviour of the patch,
 so am not marking it as resolved.)
Comment 7 Geert Stappers 2004-04-30 14:21:57 UTC 
I have seen it working as required with a so called "wrong file".
Marking it as RESOLVED and FIXED.

Be carefull with closing this bug,
as it contains a patch that is not in HEAD (main branch of CVS)
Comment 8 Geert Stappers 2004-04-30 16:00:26 UTC 
Reopening this bug.
It is not wise to have bug marked fixed,
when it is not in the main branch.
Comment 9 David Malcolm 2004-06-04 01:54:46 UTC 
I've applied this patch to HEAD; resolving as FIXED.  Thanks!