GNOME Bugzilla – Bug 129437
No option for encoding quality
Last modified: 2004-12-22 21:47:04 UTC
I couldn't find any option in the preferences or in the gconfkeys to configure options of the ogg- or mp3-encoding for soundjuicer!! (Mp3 is perhaps difficult because there are different encoders with diferrent options). What ogg-quality uses soundjuicer anyway ? (the default quality of ogg which would mean 4?). It would be just fine if you could set a quality from 1 to 10 !
As mentioned many times on the web site, and the To Do list, this is a feature still to be implemented.
Because of you, a kitten died.
Bastien -- I nearly put that this morning but realised that I said people filing duplicates kill kittens, not the quality issue. So, unless there is a duplicate (sadly you know the SJ bugs better than I do!) the kitten is alive and well... :)
Just a comment from an innocent bystander Having quality going from 1 to 10 sucks ass. What does 1 mean? What does 10 mean? In Marlin went it so that the quality slider prints strings for the quality value rather than simply a number. I just can't think of Ten different strings. I'm wanting something like "Poor Quality (Good for speeches)" "CD Quality" "Very high quality" things like that.
That is the exact reason why quality has taken so long to appear. :) I'm really thinking about using the gnome-audio-profiles stuff which just hit gnome-media HEAD.
Hy, I've suggested a list from 1 to 10 for the configuration of the encodingquality, because this is the qualityconfigurationsystem of the oggenc (the ogg-vorbis encoder). You are right, if you say that this is not a good system but your system also sucks ass. What does "Poor Quality (Good for speeches)", "CD Quality" (for some people 128kb/s for other 162kb/s for the rest 192kb/s), "Very high quality" mean?? A better system might be to configure the encodingquality with a kb/s system. (64kb/s, 128 kb/s ,162 ........) (these are naturally no exact values, because ogg vorbis works with variable bitrates).
I think quality 1-10 is the way to go - Xiph made a concious decision to change from kbps measurement to quality measurement because as new versions of ogg vorbis encoder are developed, it is possible that the same quality level will be achieved with a different kbps due to optimisation of the codec. I do agree, however, that a newbie, particularly one without any prior experience of ogg vorbis needs a way to be able to visualise the percepted audio quality. IMO, there just needs to be a legend above the slider bar indicating what setting achieves which quality. We should avoid entering the realms of telling people which quality setting is right for which purpose, as everyone hears differently, and one man's CD quality is another man's watery distortion. The most commonly used quality setting (ie a good tradeoff between quality and size) should be selected as a inital default, with the setting defaulting to the most recently selected quality with repeat uses. I propose the legend bar above the slider would like this: Lowest QUALITY Highest <------------------------------------------------------>
*** This bug has been marked as a duplicate of 134916 ***
Hmm, I marked the wrong bug as a duplicate, sorry for the noise
*** Bug 134916 has been marked as a duplicate of this bug. ***
I've submitted a patch against anoncvs to Ross today that makes sound-juicer use media profiles rather than a hard-coded set of encoders and qualities. If you want to give it a whirl (constructive feedback welcome) drop me a note and I'll send you the patch). (I'm not posting it here yet as I'd like at least one other set of eyes to take a look at it before doing so.)
If you want the code reviewed, attach it here...
> as new versions of ogg vorbis encoder are developed, it is possible that the > same quality level will be achieved with a different kbps due to optimisation > of the codec. Sure but quantity measurement (kbps) has it that you can control the average size of the encoded file. This is important with devices short on space, e.g. embeded audio players. With quality measurement you cannot say how much an average song -- say three minutes -- will weigh, unless making many tests which would only provide you the quality equivalent for, in my case, 96 kbps. I know asking for 96 kbps is just an indication for the encoder, not mandatory, but I also avoid getting files too big without being able to hear some difference in quality. Anyway I like the audio profile approach: base users will use nice default values and I would be able to make my own "best quality for lowest space" profile. I am eager to have it packaged in Debian!
I wanted the feature so I gave it a try. Patch follows. There's a slider with values between 0 and 10, with "Worst" written on the 0 side and "Best" written on the 10 side. When WAV encoding is selected, it is set to insensitive and when FLAC is selected, the labels are "Fastest" and "Best compression".
Created attachment 31678 [details] [review] implement the quality part of the prefs dialog with a slider
I thought we agreed to use sound profiles, because choosing a number is not very user-friendly?
Yes, I had. Olivier, see comment #11. Closing this bug, checkout the "sj-profiles-branch" branch to test the new code until I release it.
Yeah I coded the thing before looking in bugzilla and I did not see the profiles-branch.