GNOME Bugzilla – Bug 119112
the proxy capplet should check validity of the entered data
Last modified: 2021-06-09 16:01:58 UTC
If you select "Manual proxy configuration", and just close the dialog, when you try to open an http: url in Nautilus, you'll get "Couldn't display \"%s\", because the host name was empty. Check that your " "proxy settings are correct." This message is confusing in itself (I thought this was the host name in the URI I typed which was wrong), I'll file a bug in Nautilus. The proxy capplet should do basic checks to catch trivial proxy misconfiguration, and warn the user if it's wrong.
any suggestion on how to do that?
*** Bug 129044 has been marked as a duplicate of this bug. ***
simple test suggestions : -check string is not empty -check if string is resolved by into IP address complex test : try to connect to proxy but I don't think it is worth doing that.
(In reply to comment #3) > simple test suggestions : > -check string is not empty > -check if string is resolved by into IP address Could we make the textbox red in this case? With a little [!] on the right hand side with a tooltip? The only issue it's perfetly valid to have no https or socks proxy, so the only textbox we should do this for is the http_proxy checkbox. Does that make sense?
It's not a separate dialogue anymore, but another section in the network panel. glib-networking/libproxy should simply ignore empty hostnames (if that bug still exists obviously). Proxy support seems to be broken on my system, so I can't test whether this is still current.
There's already a bug about the glib-networking side (656917). Not sure if you moved this bug because it's already fixed on the control-center side? It seems like the control center ought to not save invalid settings to gsettings. Anyway, if this is already fixed there, then OBSOLETE. (In reply to comment #5) > Proxy support seems to be broken on my system, so I can't test whether this is > still current. If you're on F19, updating to libsoup 2.42.1 should fix it.
(In reply to comment #6) > It seems > like the control center ought to not save invalid settings to gsettings. And in fact, some programs (using libproxy, for example) parse the settings directly rather than using GProxyResolver, so there are multiple codebases out there that could be doing the wrong thing with invalid settings. So, another reason to make sure we're not writing them that way.
(In reply to comment #6) > There's already a bug about the glib-networking side (656917). Not sure if you > moved this bug because it's already fixed on the control-center side? I felt that the underlying layers should be handling invalid settings, rather than us trying to work-around the problem in the UI. > It seems > like the control center ought to not save invalid settings to gsettings. I guess so, though the exact interaction will need designer input. Marking the bug as such. > (In reply to comment #5) > > Proxy support seems to be broken on my system, so I can't test whether this is > > still current. > > If you're on F19, updating to libsoup 2.42.1 should fix it. Will update, thanks.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.