After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115705 - Button images are too large
Button images are too large
Status: RESOLVED WONTFIX
Product: gnome-applets
Classification: Other
Component: cdplayer
2.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on: 87232
Blocks:
 
 
Reported: 2003-06-22 04:29 UTC by William M. Quarles
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Attachments
CD-player applet with new, over-sized buttons (72.36 KB, image/png)
2003-06-26 03:03 UTC, William M. Quarles
Details
CD-player applet with old, good buttons (2.0.1) (71.05 KB, image/png)
2003-06-26 03:04 UTC, William M. Quarles
Details

Description William M. Quarles 2003-06-22 04:29:43 UTC
I found this entry in the changelog for the GNOME applets:

2002-10-29  Rajkumar Sivasamy <rajkumar.siva@wipro.com>

	* configure.in: Check for GDK_PIXBUF_CSOURCE
	* cdplayer/Makefile.am,
	  cdplayer/cdplayer.c,
	  cdplayer/cdplayer.h,
	  cdplayer/cdprom-interface.h: Register the cdplayer button images
	  as stock icons. Added the feature to play-pause button to have a
	  a seperate image for play and pause conditions. Also the position
	  of stop button is swapped with play/pause button.
	* cdplayer/images/*: Redrawn the existing xpm files to have a
	  white border in PNG format. Also replaced play-pause-image 
	  with two seperate files one for play and other for pause image.
	  (Thanks Suzanna for redrawing the image files)
	  Fixes bug 87232

>>>>

That's great and all, but now the buttons are too big (at least the ones 
that came on my distro) which totally defeats the purpose of the applet. 
The former, smaller buttons were much less intrusive.  Is it possible for
the buttons to be converted to a smaller format?
Comment 1 Kevin Vandersloot 2003-06-26 01:04:17 UTC
Can you post a screenshot? What version of the cdplayer applet are you
using?

This is probably fixed in 2.3.x
Comment 2 William M. Quarles 2003-06-26 03:03:15 UTC
Created attachment 17782 [details]
CD-player applet with new, over-sized buttons
Comment 3 William M. Quarles 2003-06-26 03:04:05 UTC
Created attachment 17783 [details]
CD-player applet with old, good buttons (2.0.1)
Comment 4 William M. Quarles 2003-06-26 03:04:56 UTC
I am currently using version 2.2.0.
Comment 5 Kevin Vandersloot 2003-06-26 13:38:27 UTC
Well, one of the problems from  your screenshoot it seems that the
text is probably being clipped, which is something we don't want
anymore. Another advantage in 2.3.x is that the applet is now Fitt's
law complient meaning that you can throw the mouse all the way to the
bottom and be able to click a button.

In light of this, I don't think this is a bug. You can try editing the
icons in gimp and shrinking them I suppose.
Comment 6 Chris Davidson 2003-06-26 16:34:05 UTC
I tried to reproduce this bug in dropline gnome 2.2 on a slackware 9
system and get some strange results. Depending on the size of the
panel you put it in you get different layous. The link below shows 3
different panel sizes giving me 3 different cd player applet layouts. 

http://www.personal.psu.edu/cxd401/applet


The resolution I am using is a 800x600 desktop.


Comment 7 Kevin Vandersloot 2003-06-26 20:52:17 UTC
Yah, it's supposed to change the layout depending on panel size to
save space. So what you see David is the correct behavior.

This bug is about the size of the buttons which are bigger now than
they used to be.
Comment 8 William M. Quarles 2003-06-27 02:11:20 UTC
Yes, I am aware of the behavior of the applet when you change panel
sizes.  That is normal.  What concerns me is that the button images
have become so large that the applet is not useful.  Chris's
screenshots only verify that this bug is not limited to Red Hat 9, as
the buttons are also too large with respect to the panel in his
screenshots.

I love this guy's description:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=97730

Editing the image files cannot be done, at least in RedHat's
compilation, as the images are not separate from the program when in
binary form.

Kevin, was this bug fixed in v 2.3.x or not?  I was never clear on that.
Comment 9 Kjartan Maraas 2003-10-26 10:46:53 UTC
I don't really see where bigger buttons == unusable. I think this is
just a matter of taste or getting used to it. Just saying something is
wrong or unusable doesn't make it so. I'm inclined to saying
WONTFIX/NOTABUG
Comment 10 Dennis Smit 2004-02-05 23:53:03 UTC
Totally agree, what do you think kevin ?
Comment 11 William M. Quarles 2004-02-06 02:12:11 UTC
Applets are supposed to be small.  That's why they are useful.  If
they are not small, then they are not very useful.  Taking the applet
and more than doubling its area with no improvement in the
functionality is a waste of space.  I won't use the applet any more
like that, when the regular GNOME CD Player has a nice efficient
docklet that's only 20 pixels wide  Also, as I noted earlier, there
were other complainants on the Red Hat Bugzilla about this issue.  Is
there a reason why the buttons needed to be so big to fix the bug that
inspired the change?  Because I'll edit the button images and send
them in as a patch if you guys

Also, you mentioned the text being shifted up as being a problem that
was fixed in 2.3.  I've tried 2.4, and it still looks like that.
Comment 12 Dennis Smit 2004-02-06 02:22:26 UTC
Well the point is that the icons are theme stock icons
so sending smaller version won't have any use.

I am not sure how we can solve this, anyone ?
Comment 13 Chris Davidson 2004-02-06 02:35:40 UTC
Hey guys,

 Well since this is an applet and we are pushing for svg icons in
areas of the desktop, couldn't we just shrink those kind of
components? I have not looked at this code so i am not sure how it is
setup.

Chris
Comment 14 William M. Quarles 2004-02-06 04:36:01 UTC
Pardon my lack of diction here, but what exactly do you mean by,
"theme stock icons" and "svg icons?"

Thanks,
William
Comment 15 Dennis Smit 2004-02-06 12:49:33 UTC
SVG icons are AA icons, made by vector graphics. Nowadays a great
porsion isn't based on an icon filename anymore, but the icons
are registred with a name. So you can change the icon theme
and every app that has a certain icon registred would change.
Comment 16 Dennis Smit 2004-06-04 08:54:02 UTC
I'm still tended to close this as NOTABUG, Kevin what do you think ?
Comment 17 Dennis Smit 2004-06-18 01:56:34 UTC
I'm closing this.
Comment 18 William M. Quarles 2004-06-18 05:06:55 UTC
Well, Kevin never replied.  The problem is not with the dimensions of the image
files (as you said), it has to do with how you programmed the scaling.    You
fix the problem by fixing the scaling.
Comment 19 William M. Quarles 2004-06-18 05:11:14 UTC
This is a bug, so don't resolve it with a NOTABUG.  You're proper resolution
should be WONTFIX.  I'm changing it to that.  I can't even program in C, but I'm
going to try to figure this one out, since you won't.
Comment 20 William M. Quarles 2004-06-18 05:32:54 UTC
OK, I' just tried version 2.4, and it's even worse.  You've taken what was one
of the best programs out there for GNU/Linux, one that I used to brag to people
about, and made it into a UI mockery.  I can't even get the old default layout
anymore by expanding the panel (which I could do on 2.2), and the text display
gets illegibly crammed, which I think is the same bug as the buttons not
resizing properly.  Get it together or just eliminate the applet.  I don't see
who would want to use this program anymore with what you've done to it.  Even
the people with disabilities who you are trying to serve by coming up with this
new scheme can't use the applet if they can't read the text (which also doesn't
resize, so how does that serve them?)
Comment 21 Dennis Smit 2004-06-18 13:54:12 UTC
You're so right!

Thanks for enlighten us and we're very happy you take a bite at it!