After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115247 - _NET_WM_ALLOWED_ACTIONS doesn't match allowed actions
_NET_WM_ALLOWED_ACTIONS doesn't match allowed actions
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.4.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
: 107070 439366 (view as bug list)
Depends on:
Blocks: 155453 340682
 
 
Reported: 2003-06-15 19:51 UTC by Gregory Merchan
Modified: 2007-05-19 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to clear allowed actions on startup (1.50 KB, patch)
2006-11-16 00:11 UTC, Soren Sandmann Pedersen
rejected Details | Review
Just make sure to set the allowed actions on startup, as required in the EWMH (625 bytes, patch)
2007-04-11 02:38 UTC, Elijah Newren
committed Details | Review
Adding hints for above and below actions (2.84 KB, patch)
2007-04-11 17:16 UTC, Elijah Newren
committed Details | Review

Description Gregory Merchan 2003-06-15 19:51:55 UTC
Metacity respects the Motif decoration and function hints, but does not
set _NET_WM_ALLOWED_ACTIONS to match them. Consequently, the window list
menu for a window may contain sensitive items with no effect.

Metacity version is 2.4.55 from Debian.
Comment 1 Havoc Pennington 2003-09-26 01:26:07 UTC
See also bug #94111
Comment 2 Elijah Newren 2004-10-19 21:13:09 UTC
*** Bug 107070 has been marked as a duplicate of this bug. ***
Comment 3 Elijah Newren 2005-10-07 16:08:01 UTC
Remove old target milestones on old bugs; sorry for the spam.
Comment 4 Soren Sandmann Pedersen 2006-11-16 00:11:00 UTC
Created attachment 76690 [details] [review]
Patch to clear allowed actions on startup

So one symptom of this bug is that if a different window manager, which does set the ALLOWED_ACTIONS correctly, runs in the meantime and then exits leaving the ALLOWED_ACTIONS in place on a normal window, libwnck will think that whatever the old WM thought still goes. 

This patch somewhat works around this by making metacity clear the ALLOWED_ACTIOSN on start up.

The approach of actually *setting* the allowed actions on start up would cause libwnck to not show the 'on top' menu item, since libwnck apparently treats a set ALLOWED_ACTIONS as "on top disallowed" (since _NET_WM_ACTION_ABOVE) doesn't exist.

I am applying this to RHEL5 to prevent a switch from compiz to metacity from causing libwnck to gray out its 'on top' menu item.
Comment 5 Elijah Newren 2007-04-11 02:38:53 UTC
Created attachment 86146 [details] [review]
Just make sure to set the allowed actions on startup, as required in the EWMH

The libwnck gray out on-top button item is being tracked in bug 352383.  See also http://mail.gnome.org/archives/wm-spec-list/2007-March/msg00016.html.
Comment 6 Elijah Newren 2007-04-11 02:44:27 UTC
Clearing on startup is a fine workaround for RHEL5, but moving forward it's just a different kind of violation of the spec.  We're required to set _NET_WM_ALLOWED_ACTIONS to the actual allowed actions.  (As you point out, we can't quite do that right yet, but I'll remedy that shortly after Matthias' proposal is committed to the spec.)
Comment 7 Elijah Newren 2007-04-11 17:16:57 UTC
Created attachment 86188 [details] [review]
Adding hints for above and below actions

Adding this patch for reference; I'm going to assume no one will object to the wm-spec changes and commit for now, and back out/modify later if necessary.

Putting this patch here for reference in case you want to backport to RHEL5 with the previous patch.  Of course, you'd need to patch libwnck too.
Comment 8 Elijah Newren 2007-04-11 17:35:34 UTC
(libwnck fix is at http://bugzilla.gnome.org/attachment.cgi?id=86190&action=view, which is part of bug 352383)
Comment 9 Elijah Newren 2007-05-18 13:38:14 UTC
*** Bug 439366 has been marked as a duplicate of this bug. ***
Comment 10 Oleg Sukhodolsky 2007-05-19 04:26:31 UTC
the bug is marked as fixed, but it is unclear in what version :(
could you, please, clarify this.
Comment 11 Elijah Newren 2007-05-19 15:58:20 UTC
Fixed in metacity >= 2.19.3.
Comment 12 Oleg Sukhodolsky 2007-05-19 16:13:15 UTC
thanks for information.  Am i right that there is no field with this information or I'm missing something?  (just to not repeat the same question for other bugs ;)
Comment 13 Elijah Newren 2007-05-19 16:46:03 UTC
No, there's no field with that information.  People will often say something like "I committed this to trunk and the gnome-2-18 branch" or "I applied to trunk" to let others know where it was applied.  Some may mention what the upcoming version  number of the next release will be, but that's less common.  In this case, I didn't do either, though it'd be better if I at least mentioned where I committed to (in this case, trunk only).
Comment 14 Oleg Sukhodolsky 2007-05-19 17:36:30 UTC
thank you for explanation.