After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106249 - Windows with SKIP_TASKBAR should not appear in Alt-Tab list
Windows with SKIP_TASKBAR should not appear in Alt-Tab list
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.4.x
Other Linux
: Normal normal
: METACITY2.8.x
Assigned To: Metacity maintainers list
Metacity maintainers list
: 117706 171918 (view as bug list)
Depends on:
Blocks: 155456
 
 
Reported: 2003-02-16 20:15 UTC by Sam TH
Modified: 2008-02-19 04:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Attachments
Exclude skip_pager windows from tab-list. (778 bytes, patch)
2004-07-14 08:22 UTC, fork0
needs-work Details | Review
Excludes windows with skip_taskbar set, from the alt-tab list (614 bytes, patch)
2004-08-25 15:03 UTC, Tim O'Brien
committed Details | Review
patch (811 bytes, patch)
2008-02-03 06:23 UTC, Matthias Clasen
committed Details | Review

Description Sam TH 2003-02-16 20:15:09 UTC
Windows that have both _NET_WM_STATE_SKIP_TASKBAR and
_NET_WM_STATE_SKIP_PAGER set should not appear in the list of windows
appearing on Alt-Tab.  

For example, GKrellm can be set to set these two flags, but it still
appears in the Alt-Tab list.  The only way to remove it is to make GKrellm
a panel, which is not what I want.
Comment 1 Havoc Pennington 2003-02-16 20:18:22 UTC
How do you keyboard navigate to gkrellm then?

Remember that a gnome requirement is that you can keynav everything.

(I suspect it's the same old story, gkrellm should really just be a
panel, _NET_WM_WINDOW_TYPE_DOCK)
Comment 2 Sam TH 2003-02-16 20:39:26 UTC
Well, you can make GKrellm a panel, as I mentioned, but that isn't
always what you want.  For example, panels always appear on all
workspaces.  What I really want is GKrellm to be a panel only on one
workspace, but I don't see a way to do that.

With regard to my initial suggestion, I see why the requirement for
keynav makes this impossible.  
Comment 3 Havoc Pennington 2003-02-16 22:47:00 UTC
There's been some talk of making panels per-workspace on usability@

It's possible SKIP_TASKBAR should be in Ctrl+Alt+Tab with the panels 
but I'm not sure it makes sense.
Comment 4 Rob Adams 2003-03-13 05:55:11 UTC
XMMS playlist is an example of a skip taskbar window that really does
need to be in the Alt-tab list.  I think that it's probably better to
have Alt-tab work the way it does with respect to skip tasklist, since
few users will be familiar with Ctrl+Alt+Tab.  I know I'm not.  I
didn't realize it existed till now.  And it doesn't even work for me.
 I guess I don't have anything bound to it.
Comment 5 Havoc Pennington 2003-09-25 02:46:15 UTC
We should just pick something here and implement it. My inclination is
that if a window skips both tasklist and pager, move it to ctrl+alt+tab.
Comment 6 Randy J. Ray 2003-10-03 01:04:50 UTC
I don't know if this is related or not, but since I found this bug
while searching for this issue...

When I have GAIM running, everytime I switch workspaces, it is always
given the focus. Regardless of what window had the focus when I left
that workspace. Since I have GAIM set to appear on all workspaces, I
am constantly having to Alt-Tab to restore focus to my
most-recently-chosen window. (Metacity does in fact correctly remember
the correct window in these cases, at least.)
Comment 7 Randy J. Ray 2003-10-03 01:11:39 UTC
An addendum (that I forgot while waxing on about GAIM): GKrellM will
grab the focus everytime I switch workspaces, providing GAIM doesn't
get it first. This is the case even when both of "Ignore In Tasklist"
and "Ignore On Pager" are set. So even when I minimize GAIM, I am
still forced to manually focus everytime I switch.
Comment 8 Havoc Pennington 2003-10-03 02:21:09 UTC
That's an unrelated bug; if it still happens with 2.6.2, please file a
separate bug report about it. If you're using 2.4.x, it was probably
fixed in 2.6.2.
Comment 9 fork0 2004-07-14 08:22:42 UTC
Created attachment 29526 [details] [review]
Exclude skip_pager windows from tab-list.

I don't like gkrellm to be in tablist when it selected no to be there,
and I want it to be on all workspaces, so until the discussion goes on,
the patch could be useful for someone.
It's against 2.8.1.
Comment 10 Tim O'Brien 2004-08-25 15:03:15 UTC
Created attachment 30928 [details] [review]
Excludes windows with skip_taskbar set, from the alt-tab list

I have made a similar patch to avoid having windows that include
_NET_WM_STATE_SKIP_TASKBAR in their _NET_WM_STATE appearing in the the Alt-Tab
list, it's definitely what applications expect , xmms playlist , sticky notes
gkrellm etc.
Comment 11 Havoc Pennington 2004-08-26 00:32:44 UTC
Comment on attachment 29526 [details] [review]
Exclude skip_pager windows from tab-list.

Change should be to the META_WINDOW_IN_NORMAL_TAB_CHAIN() macro, as in the
other patch here. But also remember skip_pager/skip_tasklist are two separate
items.
Comment 12 Havoc Pennington 2004-08-26 00:33:36 UTC
Comment on attachment 30928 [details] [review]
Excludes windows with skip_taskbar set, from the alt-tab list

Is it right to use only skip_taskbar, or should it be "if skip_taskbar AND
skip_pager"?

I guess my inclination is just skip_taskbar as in this patch, so this patch
looks right to me.
Comment 13 Elijah Newren 2004-10-14 20:00:14 UTC
*** Bug 117706 has been marked as a duplicate of this bug. ***
Comment 14 Elijah Newren 2004-12-24 15:44:10 UTC
Since Havoc approved it, I went ahead and committed.
Comment 15 Elijah Newren 2005-03-28 22:23:06 UTC
*** Bug 171918 has been marked as a duplicate of this bug. ***
Comment 16 Matthias Clasen 2008-02-03 06:23:16 UTC
I just discovered that the committed patch is broken and causes skip-taskbar windows to appear in neither tab list, which is a bit of an a11y problem

Here is a patch to fix this.
Comment 17 Matthias Clasen 2008-02-03 06:23:53 UTC
Created attachment 104299 [details] [review]
patch
Comment 18 Thomas Thurman 2008-02-17 23:05:49 UTC
(Marking attachment 30928 [details] [review] as committed, since it was committed in r1828 in 2004!)

http://svn.gnome.org/viewvc/metacity/trunk/src/core/window.h?r1=1826&r2=1828
Comment 19 Elijah Newren 2008-02-19 04:17:35 UTC
Matthias: Looks good to me.  I think we've got a separate bug somewhere with more thorough ideas from mpt, but nothing wrong with committing this now.
Comment 20 Matthias Clasen 2008-02-19 04:50:15 UTC
2008-02-18  Matthias Clasen  <mclasen@redhat.com>

        * src/core/window.h: Make skip-taskbar windows appear in the
        Ctrl-Alt-Tab list. Closes #106249.