After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 105834 - Startup-notification related crash [gnome_desktop_item_launch_on_screen_with_env]
Startup-notification related crash [gnome_desktop_item_launch_on_screen_with_...
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.2.x
Other Linux
: High critical
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 106356 106886 107946 123623 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-02-11 21:30 UTC by Olivier Fourdan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the memory corruption problem described (934 bytes, patch)
2003-02-11 21:31 UTC, Olivier Fourdan 		none Details | Review

Description Olivier Fourdan 2003-02-11 21:30:19 UTC 
While reviewing the code for startup notification, I found a bug that can
cause memory corruption by freeing random address when a DESKTOP_STARTUP_ID
is defined in env.

Basically, if DESKTOP_STARTUP_ID is already defines, the code in
make_spawn_environment_for_sn_context skips the string in both the source
*and* destination vector. When freed, the destination vector contains a
random value where the DESKTOP_STARTUP_ID was defined.
Comment 1 Olivier Fourdan 2003-02-11 21:31:24 UTC 
Created attachment 14265 [details] [review]
Fix the memory corruption problem described
Comment 2 Elijah Newren 2003-02-11 23:46:19 UTC 
Marking severity->critical (memory leak), priority->high (patch), and
adding bugsquad keyword.
Comment 3 Kjartan Maraas 2003-02-18 22:25:34 UTC 
*** Bug 106356 has been marked as a duplicate of this bug. ***
Comment 4 Mark McLoughlin 2003-02-18 23:40:21 UTC 
Patch looks good. Please commit to HEAD. Thanks.
Comment 5 Mark McLoughlin 2003-03-10 03:15:42 UTC 
I've gone ahead and committed it.

2003-03-10  Mark McLoughlin  <mark@skynet.ie>
                                                                     
                                       
        * gnome-desktop-item.c: (make_spawn_environment_for_sn_context):
        patch from  fourdan@xfce.org for fix memory corruption when
        DESKTOP_STARTUP_ID is already defined. bug #105834.
Comment 6 Andrew Sobala 2003-10-01 14:41:16 UTC 
*** Bug 107946 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Sobala 2003-10-01 14:41:30 UTC 
*** Bug 123623 has been marked as a duplicate of this bug. ***
Comment 8 Andrew Sobala 2003-10-01 14:41:49 UTC 
*** Bug 106886 has been marked as a duplicate of this bug. ***