GNOME Bugzilla – Bug 663889
crash due to NameDetails which fail to guarantee non-null full-name/nickname
Last modified: 2012-03-07 16:56:01 UTC
After trying to set up a connexion to my corporate jabber server ( openfire, plugged on ldap ), gnome-shell and empathy crash, with a traceback going to libfolks. It crash with the following assertion : folks:ERROR:individual.c:4841:__lambda10_: assertion failed: (name != NULL) Since the account was just created ( likely on demand ), I suspect the vcard to be empty or something like that. I run this on fedora 16, with the latest stable release ( 0.6.5 ). I have tried to use gdb, but without much success. And I will attach a debug file, even if I think the problem is that gabble or some other telepathy component feed wrong data to libfolks.
Created attachment 201265 [details] debug file before the crash
(In reply to comment #0) > After trying to set up a connexion to my corporate jabber server ( openfire, > plugged on ldap ), gnome-shell and empathy crash, with a traceback going to > libfolks. > It crash with the following assertion : > > folks:ERROR:individual.c:4841:__lambda10_: assertion failed: (name != NULL) I was able to work out the issue here, but in the future, please include a full stack trace (since I can't be sure the full path that this bug traveled, just the end point). > Since the account was just created ( likely on demand ), I suspect the vcard to > be empty or something like that. I run this on fedora 16, with the latest > stable release ( 0.6.5 ). This appears to be due to a couple of issues: 1. immediate issue: we missed some spots where we need to ensure that specific strings are always non-null. I think I've caught them all in the branch I'll be proposing as a fix 2. bigger issue: we have some assertions we should be more graceful with (see the new bug #664072)
Created attachment 201405 [details] [review] guarantee full-name and nickname fields are actually non-NULL Patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo663889-null-strings
Michael, could you please check that attachment #201405 [details] solves your problems? I didn't reproduce it myself, though it seems like this should cover any possible path.
Review of attachment 201405 [details] [review]: Looks good to me, though I haven't checked for other places where null strings could be leaking through.
Michael, any luck trying out the proposed patch?
*** Bug 664755 has been marked as a duplicate of this bug. ***
This should fix the crash a couple people have seen: commit 50bc2ead6f963da7942d1c06cdd5e1a9e354fc85 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Mon Nov 14 14:29:21 2011 -0800 Ensure NameDetails public strings are non-null as we promise. Closes: bug#663889 - crash due to NameDetails which fail to guarantee non-null full-name/nickname NEWS | 2 ++ backends/eds/lib/edsf-persona.vala | 2 ++ backends/telepathy/lib/tpf-persona.vala | 2 ++ backends/tracker/lib/trf-persona.vala | 2 ++ 4 files changed, 8 insertions(+), 0 deletions(-)
I finally got the time for testing it, sorry to not have done earlier. It still crash with the same message message in .xsession-errors : folks:ERROR:individual.c:4841:__lambda10_: assertion failed: (name != NULL) Could it be that the profile is stored somewhere, and that I need to clean it up ? ( since another tester said this fixed the crash for him on https://admin.fedoraproject.org/updates/FEDORA-2011-16497/folks-0.6.5-2.fc16 ). I will try to get a backtrace later today.
Is this still a problem with version 0.6.7?
Those who were experiencing crashes even with that Fedora package update are happy with folks-0.6.6: https://bugzilla.redhat.com/760542
(In reply to comment #11) > Those who were experiencing crashes even with that Fedora package update are > happy with folks-0.6.6: https://bugzilla.redhat.com/760542 Closing in that case. Thanks for following up!