After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607674 - _pygi_import shouldn't raise an error if pygi support is disabled
_pygi_import shouldn't raise an error if pygi support is disabled
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: gobject
Git master
Other Linux
: High critical
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-21 16:30 UTC by Simon van der Linden
Modified: 2010-02-02 21:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't raise an error in_pygi_import if pygi support is disabled (2.43 KB, patch)
2010-01-21 16:50 UTC, Simon van der Linden 		committed Details | Review

Description Simon van der Linden 2010-01-21 16:30:29 UTC 
Functions like pyg_boxed_new, pyg_pointer_new, and pygobject_lookup_class used to clear the error anyway, but others (i.e. pyg_enum_from_gtype and pyg_flags_from_enum) didn't.

It's safer not to raise an error when pygi is disabled and not to clear errors in functions cited above, in case pygi is enabled.
Comment 1 Simon van der Linden 2010-01-21 16:50:09 UTC 
Created attachment 151950 [details] [review]
Don't raise an error in_pygi_import if pygi support is disabled
Comment 2 Gian Mario Tagliaretti 2010-02-02 20:38:32 UTC 
Simon I've marked the patch as commit now few time ago
Comment 3 Simon van der Linden 2010-02-02 21:12:37 UTC 
Review of attachment 151950 [details] [review]:

Sorry, I didn't notice. Thanks!

Committed as 23fc0f6.